ampproject · xiexr151e · Jan 31, 2020 · Feb 4, 2020 · Apr 27, 2020 · Jul 10, 2020
diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md
@@ -0,0 +1 @@
+See https://github.com/ampproject/meta/blob/master/CODE_OF_CONDUCT.md
diff --git a/transformer/transformer.go b/transformer/transformer.go
@@ -44,6 +44,7 @@ var transformerFunctionMap = map[string]func(*transformers.Context) error{
 	"absoluteurl":           transformers.AbsoluteURL,
 	"ampboilerplate":        transformers.AMPBoilerplate,
 	"ampruntimecss":         transformers.AMPRuntimeCSS,
+	"ampruntimejs":			 transformers.AMPRuntimeJS,
 	"linktag":               transformers.LinkTag,
 	"nodecleanup":           transformers.NodeCleanup,
 	"preloadimage":          transformers.PreloadImage,
@@ -72,6 +73,7 @@ var configMap = map[rpb.Request_TransformersConfig][]func(*transformers.Context)
 		transformers.AMPRuntimeCSS,
 		transformers.TransformedIdentifier,
 		transformers.URLRewrite,
+		transformers.AMPRuntimeJS,
 		transformers.PreloadImage,
 		// ReorderHead should run after all transformers that modify the
 		// <head>, as they may do so without preserving the proper order.

diff --git a/transformer/transformers/ampruntimejs.go b/transformer/transformers/ampruntimejs.go
@@ -0,0 +1,29 @@
+package transformers
+
+import (
+	"regexp"
+	"strings"
+
+	"github.com/ampproject/amppackager/transformer/internal/amphtml"
+	"github.com/ampproject/amppackager/transformer/internal/htmlnode"
+	"golang.org/x/net/html/atom"
+	"golang.org/x/net/html"
+)
+
+// AMPRuntimeJS rewrites the value of src in script nodes, where applicable.
+// If the value is of the form "*.js", replace it with "*.sxg.js".
+func AMPRuntimeJS(e *Context) error {
+	for n := e.DOM.RootNode; n != nil; n = htmlnode.Next(n) {
+		if n.Type != html.ElementNode {
+			continue
+		}
+		if n.DataAtom == atom.Script {
+			if src, ok = htmlnode.FindAttribute(n, "", "src"); ok && strings.hasPrefix(src.Val, amphtml.AMPCacheRootURL) && strings.HasSuffix(src.Val, ".js"){
+				src.Val = strings.TrimSuffix(src.Val, ".js") + ".sxg.js"
+			}
+		} else {
+			continue
+		}
+	}
+	return nil
+}
diff --git a/transformer/transformers/ampruntimejs_test.go b/transformer/transformers/ampruntimejs_test.go
@@ -0,0 +1,70 @@
+package transformers_test
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/ampproject/amppackager/transformer/internal/amphtml"
+	tt "github.com/ampproject/amppackager/transformer/internal/testing"
+	"github.com/ampproject/amppackager/transformer/transformers"
+	"golang.org/x/net/html"
+)
+
+func TestStripJS(t *testing.T) {
+	tcs := []tt.TestCase{
+		{
+			Desc:     "no script node",
+			Input:    "<head></head><body></body>",
+			Expected: "<head></head><body></body>",
+		},
+		{
+			Desc:     "no prefix",
+			Input:    "<script src=main.js/>",
+			Expected: "<script src=main.js/>",
+		},
+		{
+			Desc:     "no suffix",
+			Input:    "<script src=\"https://cdn.ampproject.org\"/>",
+			Expected: "<script src=\"https://cdn.ampproject.org\"/>",
+		},
+		{
+			Desc:     "transformation",
+			Input:    "<script async src=\"https://cdn.ampproject.org/v0.js\"></script>",
+			Expected: "<script async src=\"https://cdn.ampproject.org/v0.sxg.js\"></script>",
+		},
+	}
+
+	for _, tc := range tcs {
+		inputDoc, err := html.Parse(strings.NewReader(tc.Input))
+		if err != nil {
+			t.Errorf("%s: html.Parse failed %q", tc.Input, err)
+			continue
+		}
+		inputDOM, err := amphtml.NewDOM(inputDoc)
+		if err != nil {
+			t.Errorf("%s\namphtml.NewDOM for %s failed %q", tc.Desc, tc.Input, err)
+			continue
+		}
+		transformers.AMPRuntimeJS(&transformers.Context{DOM: inputDOM})
+		var input strings.Builder
+		if err := html.Render(&input, inputDoc); err != nil {
+			t.Errorf("%s: html.Render failed %q", tc.Input, err)
+			continue
+		}
+
+		expectedDoc, err := html.Parse(strings.NewReader(tc.Expected))
+		if err != nil {
+			t.Errorf("%s: html.Parse failed %q", tc.Expected, err)
+			continue
+		}
+		var expected strings.Builder
+		err = html.Render(&expected, expectedDoc)
+		if err != nil {
+			t.Errorf("%s: html.Render failed %q", tc.Expected, err)
+			continue
+		}
+		if input.String() != expected.String() {
+			t.Errorf("%s: Transform=\n%q\nwant=\n%q", tc.Desc, &input, &expected)
+		}
+	}
+}