Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The api task os role zabbix_agent should be executed with explicit become false #1393

Merged

Conversation

emrocha
Copy link
Contributor

@emrocha emrocha commented Sep 14, 2024

SUMMARY

Undo some changes of commit 5480ff7

The community.zabbix.zabbix_host module with the delegate_to parameter should not be executed with "become true" if the role zabbix_agent is applied with "become true".

It is possible that the user executing the ansible script has sudo permission on the remote computer that the zabbix_agent role will be executed on, but does not have sudo permission on the local computer from which the ansible script is initially executed.

The same applies to the other modules of this task.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

role zabbix_agent

Undo some changes of commit 5480ff7 

The community.zabbix.zabbix_host module with the delegate_to parameter should not be executed with "become true" if the role zabbix_agent is applied with "become true".

It is possible that the user executing the ansible script has sudo permission on the remote computer that the zabbix_agent role will be executed on, but does not have sudo permission on the local computer from which the ansible script is initially executed.

The same applies to the other modules of this task.
@pyrodie18
Copy link
Collaborator

@BGmot see any issues with this? I don't think it will break anything.

@pyrodie18
Copy link
Collaborator

@emrocha add a change fragment please

@emrocha
Copy link
Contributor Author

emrocha commented Sep 14, 2024

@pyrodie18
By "add a changelog fragment please", do you mean edit the changelogs/fragments/monitored_by.yml file or create a new file in this directory? Or something else?

@pyrodie18 pyrodie18 merged commit 7d7e704 into ansible-collections:main Sep 15, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants