Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce explaining variable refactoring. #170

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Vivek504
Copy link

Introduce Explaining Variable Refactoring

Reason: Long Statement

  1. The length of the statement "final MethodHandle nonNullTest=lookup.findStatic(Objects.class,"nonNull",methodType(boolean.class,Object.class)).asType(methodType(boolean.class,cleanerClass));" is 160.
  2. The length of the statement "final MethodHandle unmapper=filterReturnValue(directBufferCleanerMethod,guardWithTest(nonNullTest,cleanMethod,noop)).asType(methodType(void.class,ByteBuffer.class));" is 165.

Logic of the refactoring: Complicated expressions are replaced by explaining variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant