Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix sdk dead links #5086

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

nisiyong
Copy link
Member

@nisiyong nisiyong commented Feb 1, 2024

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73b4b84) 49.59% compared to head (ccf05a5) 49.65%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5086      +/-   ##
============================================
+ Coverage     49.59%   49.65%   +0.06%     
- Complexity     1907     1908       +1     
============================================
  Files           372      372              
  Lines         11564    11564              
  Branches       1127     1127              
============================================
+ Hits           5735     5742       +7     
+ Misses         5486     5479       -7     
  Partials        343      343              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 1, 2024
@shoothzj shoothzj merged commit 921af84 into apolloconfig:master Feb 1, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@nisiyong nisiyong deleted the fix-dead-links branch February 1, 2024 12:48
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants