Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): history error reported in the dev environment #20133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui): history error reported in the dev environment #20133

wants to merge 1 commit into from

Conversation

youhonglian
Copy link

@youhonglian youhonglian commented Sep 27, 2024 •
edited
Loading

close #20132

before.mov

This is a before video.

after.mov

This is an after video

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@youhonglian youhonglian requested a review from a team as a code owner September 27, 2024 08:27
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 27, 2024 •
edited
Loading

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Sep 27, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

linghaoSu
linghaoSu approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@linghaoSu linghaoSu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for correcting my fault. It seems I have forgotten to delete redundant code here 😓

Maybe you can change the pr title to start with fix(ui):

nitishfy
nitishfy suggested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commits for DCO check to get passed.

@youhonglian
Copy link
Author

Please sign the commits for DCO check to get passed.

@nitishfy Thank you for your reminder, I have signed the commit

@youhonglian youhonglian changed the title fix: history error reported in the dev environment fix(ui): history error reported in the dev environment Sep 29, 2024
@youhonglian
Copy link
Author

LGTM! Thank you for correcting my fault. It seems I have forgotten to delete redundant code here 😓

Maybe you can change the pr title to start with fix(ui):

@linghaoSu Thank you for your reminder , I have changed the PR title

nitishfy
nitishfy reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Can you paste the before vs after here?

@youhonglian
Copy link
Author

youhonglian commented Sep 30, 2024 •
edited
Loading

Overall LGTM. Can you paste the before vs after here?

I've updated the description with two videos

crenshaw-dev
crenshaw-dev reviewed Sep 30, 2024
View reviewed changes
ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx
Comment on lines -94 to -95
history.replaceState(null, '', `${location.pathname}?${queryParams}`);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any sense why this was present in the first place? Can we be confident that it's not needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind the original author gave it the thumbs-up. @linghaoSu how far back do we need to cherry-pick this?

Copy link
Contributor

@linghaoSu linghaoSu Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the commit this bug introduced, this change does not ship in any RC or stable version. We don't need to cherry-pick, merging this into the master branch is enough.

40c6077

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves it for me.

@crenshaw-dev
Copy link
Member

/bns:deploy

todaywasawesome
todaywasawesome approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

ui/src/app/applications/components/pod-logs-viewer/pod-logs-viewer.tsx
Comment on lines -94 to -95
history.replaceState(null, '', `${location.pathname}?${queryParams}`);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev left review comments

@linghaoSu linghaoSu linghaoSu approved these changes

@todaywasawesome todaywasawesome todaywasawesome approved these changes

@nitishfy nitishfy nitishfy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error occurs when staying on the pod log page
5 participants
@youhonglian @crenshaw-dev @todaywasawesome @linghaoSu @nitishfy