-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): run UI e2e tests #20200
base: master
Are you sure you want to change the base?
feat(ci): run UI e2e tests #20200
Conversation
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
Signed-off-by: Michael Crenshaw <[email protected]> found a better place for e2e tests Signed-off-by: Michael Crenshaw <[email protected]> do things faster Signed-off-by: Michael Crenshaw <[email protected]> remove unnecessary env vars Signed-off-by: Michael Crenshaw <[email protected]> use same env var as CI already uses Signed-off-by: Michael Crenshaw <[email protected]> do things that supposedly make things work Signed-off-by: Michael Crenshaw <[email protected]> things aren't working, so log more Signed-off-by: Michael Crenshaw <[email protected]> flail Signed-off-by: Michael Crenshaw <[email protected]> install chromedriver Signed-off-by: Michael Crenshaw <[email protected]> don't ignore .env Signed-off-by: Michael Crenshaw <[email protected]> log stuff Signed-off-by: Michael Crenshaw <[email protected]> who knows Signed-off-by: Michael Crenshaw <[email protected]> who knows Signed-off-by: Michael Crenshaw <[email protected]> save server logs Signed-off-by: Michael Crenshaw <[email protected]> exit 1 on error Signed-off-by: Michael Crenshaw <[email protected]> webpack URL, longer timeout Signed-off-by: Michael Crenshaw <[email protected]> more logging, CSS instead of xpath Signed-off-by: Michael Crenshaw <[email protected]> shut down goreman after running tests Signed-off-by: Michael Crenshaw <[email protected]> better shutdown method? Signed-off-by: Michael Crenshaw <[email protected]> ? Signed-off-by: Michael Crenshaw <[email protected]> proxy the correct port Signed-off-by: Michael Crenshaw <[email protected]> login, to be polite Signed-off-by: Michael Crenshaw <[email protected]> give the controller more time to spin up Signed-off-by: Michael Crenshaw <[email protected]> handle e2e ns Signed-off-by: Michael Crenshaw <[email protected]> run e2e tests Signed-off-by: Michael Crenshaw <[email protected]> clean up Signed-off-by: Michael Crenshaw <[email protected]>
c42368d
to
78007da
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20200 +/- ##
==========================================
- Coverage 55.89% 49.36% -6.54%
==========================================
Files 322 322
Lines 44499 44499
==========================================
- Hits 24874 21966 -2908
- Misses 17057 20048 +2991
+ Partials 2568 2485 -83 ☔ View full report in Codecov by Sentry. |
Based on codecov output, looks like I managed to prevent coverage being reported from e2e tests. 0_o |
@crenshaw-dev I'm curious to know how did you test those changes out for the CI before raising the PR? |
Looked the the ui-test directory was mostly going unused. I got the tests working in CI, so hopefully that'll make the tests more useful.