-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo-server): unify semver resolution in new versions subpackage #20216
Open
PaulSonOfLars
wants to merge
5
commits into
argoproj:master
Choose a base branch
from
PaulSonOfLars:paul/unify-semver-resolution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(repo-server): unify semver resolution in new versions subpackage #20216
PaulSonOfLars
wants to merge
5
commits into
argoproj:master
from
PaulSonOfLars:paul/unify-semver-resolution
+213
−313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Larsen <[email protected]>
Signed-off-by: Paul Larsen <[email protected]>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far! Just a few minor comments
I think you also need to run |
blakepettersson
changed the title
fix: Unify semver resolution in new versions subpackage
fix: unify semver resolution in new versions subpackage
Oct 4, 2024
Signed-off-by: Paul Larsen <[email protected]>
Signed-off-by: Paul Larsen <[email protected]>
PaulSonOfLars
force-pushed
the
paul/unify-semver-resolution
branch
from
October 4, 2024 18:32
a68229a
to
bbe0191
Compare
blakepettersson
changed the title
fix: unify semver resolution in new versions subpackage
refactor(repo-server): unify semver resolution in new versions subpackage
Oct 4, 2024
blakepettersson
changed the title
refactor(repo-server): unify semver resolution in new versions subpackage
chore(repo-server): unify semver resolution in new versions subpackage
Oct 4, 2024
Signed-off-by: Paul Larsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify semver resolution across helm/OCI/git into a single package, to ensure we don't end up with mismatched logic for different services
Follow up to #20096, as requested here. cc @blakepettersson
Checklist: