feat(applicationset): Add FlatList option to cluster generator - Fixes #20212

[OpenGuidou]

Fixes #20212

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

✅ Preview Environment deployed on Bunnyshell

Component	Endpoints
argocd	https://argocd-5iv6kn.bunnyenv.com/
argocd-ttyd	https://argocd-web-cli-5iv6kn.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔴 /bns:stop to stop the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[bunnyshell]

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[speedfl]

LGTM !

[speedfl]

@OpenGuidou Maybe the array will be overridden if we have multiple cluster generator. Could you please test it ?

[OpenGuidou]

@OpenGuidou Maybe the array will be overridden if we have multiple cluster generator. Could you please test it ?

As the values and template can be different in each cluster generator, I would not risk to flat list the flat lists 😄
I would say, if you agree, that it's acceptable to keep the factorization to a single cluster generator only.

[speedfl]

@OpenGuidou Maybe the array will be overridden if we have multiple cluster generator. Could you please test it ?

As the values and template can be different in each cluster generator, I would not risk to flat list the flat lists 😄 I would say, if you agree, that it's acceptable to keep the factorization to a single cluster generator only.

You are right. We will have one app per generator. We will then have one app of n clusters and one app of m clusters. So it should not be a problem.

[speedfl]

@ishitasequeira if you have some time 🙂

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.98%. Comparing base (1c6ec19) to head (228b6ab).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #20231      +/-   ##
==========================================
+ Coverage   55.96%   55.98%   +0.02%     
==========================================
  Files         322      322              
  Lines       44546    44559      +13     
==========================================
+ Hits        24929    24948      +19     
  Misses      17049    17049              
+ Partials     2568     2562       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.