Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notifications not being delivered when using sources in Application #20237

Merged

Conversation

ajinkyak423
Copy link
Contributor

@ajinkyak423 ajinkyak423 commented Oct 5, 2024

related issue: #19766

fixed:

  1. Notifications not being sent when sources is used for multi-source applications.
  • added emojis and singular - plural i.e. "Repository" "Repositories" action based on use of source and sources respectively.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@ajinkyak423 ajinkyak423 requested review from a team as code owners October 5, 2024 14:12
Copy link

bunnyshell bot commented Oct 5, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Oct 5, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@ajinkyak423 ajinkyak423 changed the title Fix notifications not being delivered when using sources in Application fix: Notifications not being delivered when using sources in Application Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@40c6077). Learn more about missing BASE report.
Report is 66 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20237   +/-   ##
=========================================
  Coverage          ?   55.96%           
=========================================
  Files             ?      322           
  Lines             ?    44607           
  Branches          ?        0           
=========================================
  Hits              ?    24963           
  Misses            ?    17059           
  Partials          ?     2585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit 52d5653 into argoproj:master Oct 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants