Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updates the isTscMember property and manages changes in the tsc_members teams #807

Merged
merged 24 commits into from
Aug 3, 2023

Conversation

14Richa
Copy link
Contributor

@14Richa 14Richa commented Jul 21, 2023

Description

This pull request introduces a workflow named TSC Management Workflow which manages changes to the tsc_members team. The workflow is automatically triggered when a pull request is merged, and it specifically detects changes in the 'MAINTAINERS.yaml' file. It consists of several jobs that run sequentially to detect changes, update the TSC team, notify the community, and maintain the Emeritus list.

  • detect_tsc_membership_changes: Compares MAINTAINERS.yaml between the main branch and pull request to detect TSC member changes.
  • add_tsc_member: Adds new TSC members to the tsc_members teams.
  • display_message: Filters new TSC members and posts a welcome message to them on the pull request.
  • remove_tsc_member: Removes specified TSC members from the tsc_members teams.
  • remove_tsc_goodbye: Posts a farewell message to removed TSC members on the pull request.
  • update_emeritus: Updates Emeritus.yaml with the latest TSC member list and creates a pull request for the changes.

Testing and Logs:

This workflow has been thoroughly tested in my TestRepo. The test logs for scenarios when adding and removing TSC members can be accessed below:

  1. Test Scenario: Adding a TSC Member
  2. Test Scenario: Removing a TSC Member

@14Richa 14Richa marked this pull request as ready for review July 26, 2023 10:12
.github/workflows/update-tsc.yml Outdated Show resolved Hide resolved
.github/workflows/update-tsc.yml Outdated Show resolved Hide resolved
.github/workflows/update-tsc.yml Outdated Show resolved Hide resolved
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just one small suggestion. 👍

.github/workflows/tsc_management.yml Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Aug 3, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit c55e80c into asyncapi:master Aug 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants