Fixup documentation briefly for sortShorthand
#1718
Conversation
kylorhall-atlassian
requested review from
JakeLane,
pancaspe87,
liamqma and
dddlr
as code owners
|
✅ Deploy Preview for compiled-css-in-js canceled.
|
| @@ -116,14 +116,3 @@ See [Shorthand properties](/shorthand) for more information. | |||
|
|
|||
| - Type: `boolean` | |||
| - Default: `false` | |||
|
|
|||
| #### sortShorthand | |||
There was a problem hiding this comment.
This is just a duplicate (the section above is the same)
| ```js | ||
| { | ||
| loader: '@compiled/webpack-loader', | ||
| options: { sortShorthand: true } |
There was a problem hiding this comment.
Is this even right? It's a bit unclear to me…
There was a problem hiding this comment.
docs changes look reasonable, let me double check in the repo
There was a problem hiding this comment.
oh this is incorrect, sortShorthand exists for CompiledExtractPlugin but not @compiled/webpack-loader
see current docs https://compiledcssinjs.com/docs/pkg-webpack-loader where sortShorthand is listed under the options for CompiledExtractPlugin but not listed under the options for @compiled/webpack-loader
There was a problem hiding this comment.
Oh, I got how this documentation works now 😅 I'll just keep the example so someone doesn't misunderstand it like I did.
There was a problem hiding this comment.
Both fixed in f8d041e
kylorhall-atlassian
force-pushed
the
kylorhall/sortshorthand-documentation
branch
from
f8d041e
to
a3843bd
Compare
kylorhall-atlassian
force-pushed
the
kylorhall/sortshorthand-documentation
branch
from
a3843bd
to
7122c7d
Compare
What is this change?
Updating documentation around the
sortShorthandconfig as I was confused myself setting it up in a new repo.PR checklist
Updated or added applicable tests– n/awebsite/