-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flat config preset for compiled & fix docs #1727
base: master
Are you sure you want to change the base?
Add flat config preset for compiled & fix docs #1727
Conversation
🦋 Changeset detectedLatest commit: 9c4a24e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for compiled-css-in-js canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can see you really uplifted things a bit! I've got no concerns with this having interacted on the other plugins you've uplifted!
Worth an FYI review from the owners still though!
@@ -5,6 +5,8 @@ import { createNoTaggedTemplateExpressionRule, isKeyframes } from '../../utils'; | |||
export const noKeyframesTaggedTemplateExpressionRule: Rule.RuleModule = { | |||
meta: { | |||
docs: { | |||
recommended: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a few recommended: true
could be a problem, but this is a minor bump on a 0.x
version which means major to me, LGTM if Eurybia is happy!
get '@compiled'() { | ||
return plugin; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit more coherent than plugin.configs['flat/recommended'].plugins['@compiled'] = plugin
which is what you'd have to do otherwise, right?
Only real concern is could this ever backfire with some Node support? I feel like it's been around forever but also a syntax I never use (because when it was introduced it wasn't ready to be used)…it's good now, right?
Also, would you ever want to merge this though?
get '@compiled'() { | |
return plugin; | |
}, | |
...flatRecommended.plugins, | |
get '@compiled'() { | |
return plugin; | |
}, |
What is this change?
This PR:
Why are we making this change?
@compiled/eslint-plugin
can use this with flat config without the legacy compat utilsPR checklist
Don't delete me!
I have...
website/
Closes #1691