Clean Up - 'compatibleWithPreviousVersion' for 'getMetaData()' and 'g…

…etClientInfo()' (#184) Co-authored-by: Hannah Chan <[email protected]>
atlassian-labs · Sep 27, 2023 · 096dcc0 · 096dcc0
1 parent 988eb0e
commit 096dcc0
Showing 1 changed file with 7 additions and 23 deletions.
diff --git a/src/main/java/com/atlassian/db/replica/api/DualConnection.java b/src/main/java/com/atlassian/db/replica/api/DualConnection.java
@@ -182,11 +182,7 @@ public boolean isClosed() {
     @Override
     public DatabaseMetaData getMetaData() throws SQLException {
         checkClosed();
-        if (compatibleWithPreviousVersion) {
-            return connectionProvider.getWriteConnection(new RouteDecisionBuilder(Reason.RW_API_CALL)).getMetaData();
-        } else {
-            return connectionProvider.getReadConnection(new RouteDecisionBuilder(Reason.RO_API_CALL)).getMetaData();
-        }
+        return connectionProvider.getReadConnection(new RouteDecisionBuilder(Reason.RO_API_CALL)).getMetaData();
     }
 
     @Override
@@ -545,29 +541,17 @@ public void setClientInfo(Properties properties) throws SQLClientInfoException {
     @Override
     public String getClientInfo(String name) throws SQLException {
         checkClosed();
-        if (compatibleWithPreviousVersion) {
-            return connectionProvider
-                .getWriteConnection(new RouteDecisionBuilder(Reason.RW_API_CALL))
-                .getClientInfo(name);
-        } else {
-            return connectionProvider
-                .getReadConnection(new RouteDecisionBuilder(Reason.RO_API_CALL))
-                .getClientInfo(name);
-        }
+        return connectionProvider
+            .getReadConnection(new RouteDecisionBuilder(Reason.RO_API_CALL))
+            .getClientInfo(name);
     }
 
     @Override
     public Properties getClientInfo() throws SQLException {
         checkClosed();
-        if (compatibleWithPreviousVersion) {
-            return connectionProvider
-                .getWriteConnection(new RouteDecisionBuilder(Reason.RW_API_CALL))
-                .getClientInfo();
-        } else {
-            return connectionProvider
-                .getReadConnection(new RouteDecisionBuilder(Reason.RO_API_CALL))
-                .getClientInfo();
-        }
+        return connectionProvider
+            .getReadConnection(new RouteDecisionBuilder(Reason.RO_API_CALL))
+            .getClientInfo();
     }
 
     @Override