Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for custom connection provider for replica discovery #180

Conversation

wyrzyk
Copy link
Contributor

@wyrzyk wyrzyk commented Jul 24, 2023

…AuroraMultiReplicaConsistency`

@wyrzyk wyrzyk marked this pull request as ready for review July 24, 2023 08:16
@wyrzyk wyrzyk requested a review from a team as a code owner July 24, 2023 08:16
Copy link
Contributor

@bilalshehata bilalshehata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyrzyk wyrzyk merged commit 9268b14 into atlassian-labs:master Jul 24, 2023
1 check passed
@wyrzyk
Copy link
Contributor Author

wyrzyk commented Jul 25, 2023

We are discovering replicas during isConsistent check. Previously we used a replica connection as a consistency check method parameter. Later, the same connection was reused for the consistency check and hopefully for the user query. This connection was part of the DB replica connection lifecycle and the connection was eventually closed when no longer needed.
Yesterday I introduced changes where we inject the connection provider outside of the lifecycle, but I forgot that it now needs to be closed manually. The fix ensures that the connection is closed, while leaving the old path (detecting replicas with a replica connection) unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants