remove mac terraform resource #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you link to the last PR that got merged that caused this issue? Doesn't look like we're doing a revert, so there's no way for me to know where this change is coming from. |
| @@ -42,11 +42,11 @@ func Validate() error { | |||
| }, | |||
| } | |||
|
|
|||
| expectedMetrics := []string{"mem_used_percent", "cpu_time_active_userdata", "disk_free"} | |||
| expectedMetrics := []string{"memory", "cpu_time_active_userdata", "disk_free"} | |||
There was a problem hiding this comment.
Good catch. I missed this in the other review
| receivers: ["system"] | ||
|
|
||
| #Test case name | ||
| test_case: "win_restart" |
There was a problem hiding this comment.
This doesn't look like it should be for win_restart
| values_per_minute: "2" | ||
| agent_collection_period: 60 | ||
| cloudwatch_agent_config: "<cloudwatch_agent_config>" | ||
| metric_namespace: "CloudWatchAgentWinFeature" |
There was a problem hiding this comment.
I think this is probably just a copy paste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Last changes are breaking mac tests and multi_config tests
Description of changes
revert mac resource changes and multi_config test. All tests except
o7andwin2012are passing after reverting changeshttps://github.com/aws/private-amazon-cloudwatch-agent-staging/actions/runs/5535298334/jobs/10101621606
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.