Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(awscore): Update JavaDoc for AwsServiceException #5513

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

risto-liftoff
Copy link

Motivation and Context

I noticed the documentation for AwsServiceException references errorType which doesn't exist on the class. This appears to be a copy-paste artifact from v1 of the SDK.

Modifications

Removes the incorrect sentence.

Testing

Did not test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@risto-liftoff risto-liftoff requested a review from a team as a code owner August 16, 2024 00:21
@debora-ito
Copy link
Member

@risto-liftoff spot on, thank you for the fix. Can you also change "AmazonServiceException" to "AwsServiceException"?

@risto-liftoff
Copy link
Author

Can you also change "AmazonServiceException" to "AwsServiceException"?

Done, good catch.

@risto-liftoff
Copy link
Author

@debora-ito would you be able to approve and merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants