Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed order of method calls in ProfileCredentialsProvider resolveCredentials method #5624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piotr-goetz-duco
Copy link

Problem - incorrect order of method calls

The handleProfileFileReload(cachedOrRefreshedProfileFile) method should be called before updating the currentProfileFile to ensure that the credentials provider is updated with the new profile file before it is set as the current profile file.

Motivation and Context

#5001
This change ensures that any subsequent calls to resolveCredentials method will use updated credentials provider.

Modifications

Moved the handleProfileFileReload(cachedOrRefreshedProfileFile) call before the currentProfileFile = cachedOrRefreshedProfileFile assignment.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@piotr-goetz-duco piotr-goetz-duco requested a review from a team as a code owner September 25, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant