Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: cwsprChatUserIntent #864

Merged
merged 3 commits into from
Sep 25, 2024
Merged

telemetry: cwsprChatUserIntent #864

merged 3 commits into from
Sep 25, 2024

Conversation

lalexcaws
Copy link
Contributor

Problem

Plugins telemetry data should now include the user intent as part of message interaction

Solution

Modify common definition to include user intent

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lalexcaws lalexcaws requested a review from a team as a code owner September 24, 2024 21:35
@justinmk3
Copy link
Contributor

CI is failing

do you also plan to remove the toolkit-local definition here: https://github.com/aws/aws-toolkit-vscode/blob/1db0f973b1db2011cc442b5c78e7fac186cd1d4e/packages/core/src/shared/telemetry/vscodeTelemetry.json#L811 (it should be upstreamed/synced with this common definition)

@lalexcaws
Copy link
Contributor Author

CI is failing

do you also plan to remove the toolkit-local definition here: https://github.com/aws/aws-toolkit-vscode/blob/1db0f973b1db2011cc442b5c78e7fac186cd1d4e/packages/core/src/shared/telemetry/vscodeTelemetry.json#L811 (it should be upstreamed/synced with this common definition)

Yeah, I can remove the local definition once this common definition is done

@hayemaxi
Copy link
Contributor

hayemaxi commented Sep 25, 2024

CI is failing
do you also plan to remove the toolkit-local definition here: https://github.com/aws/aws-toolkit-vscode/blob/1db0f973b1db2011cc442b5c78e7fac186cd1d4e/packages/core/src/shared/telemetry/vscodeTelemetry.json#L811 (it should be upstreamed/synced with this common definition)

Yeah, I can remove the local definition once this common definition is done

Please make an internal ticket to ensure this is tracked (if not already tracked from #5654)

@hayemaxi
Copy link
Contributor

Thank you for porting this quickly!

@justinmk3 justinmk3 changed the title Include user intent in message interaction telemetry: cwsprChatUserIntent Sep 25, 2024
@justinmk3 justinmk3 merged commit 2742ed4 into aws:main Sep 25, 2024
8 checks passed
@lalexcaws lalexcaws deleted the user-intent branch September 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants