Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add refresh button to regionSubmenu #5641

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Hweinstock
Copy link
Contributor

Problem

Originally, wanted refresh for EC2 connect QuickPick so that we can update instance status in the QuickPick.
This problem can be generalized to all users of the regionSubmenu.

Solution

Add refresh button to regionSubmenu.

Implementation Details

  • Testing the refresh is a little awkward. There is a comment in the packages/core/src/test/shared/ui/prompters/regionSubmenu.test.ts file explaining the choices made.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock requested a review from a team as a code owner September 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant