Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events #5768

Merged
merged 10 commits into from
Oct 15, 2024

Conversation

laileni-aws
Copy link
Contributor

@laileni-aws laileni-aws commented Oct 10, 2024

Problem

  • Client side telemetry event interactWithMessage is missing cwsprChatProgrammingLanguage parameter which helps to understand the language of generated code.

Solution


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@laileni-aws laileni-aws marked this pull request as ready for review October 10, 2024 23:17
@laileni-aws laileni-aws requested review from a team as code owners October 10, 2024 23:17
@laileni-aws laileni-aws marked this pull request as draft October 15, 2024 18:23
@laileni-aws laileni-aws changed the title telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events WIP: telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events Oct 15, 2024
@laileni-aws laileni-aws marked this pull request as ready for review October 15, 2024 18:34
@laileni-aws laileni-aws changed the title WIP: telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events Oct 15, 2024
@@ -582,7 +587,8 @@ export const createMynahUI = (
eventId,
codeBlockIndex,
totalCodeBlocks,
messageUserIntentMap.get(messageId) ?? undefined
responseMetadata.get(messageId)?.[0] ?? undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add these to ViewDiff and AcceptDiff as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that can be in different PR as these two are unavailable for Generate Tests(Beta).
@ivikash Correct me on this!

@justinmk3
Copy link
Contributor

justinmk3 commented Oct 15, 2024

npm ERR! Invalid: lock file's @aws-toolkits/[email protected] does not satisfy @aws-toolkits/[email protected]

use npm install --save (or --save-dev) when updating dependencies.

@justinmk3
Copy link
Contributor

Thanks for upstreaming the metric to common. The build is failing because the old local metric still exists and overrides the common one. You need to delete it (in this PR):

"name": "amazonq_interactWithMessage",

@justinmk3 justinmk3 merged commit f3d0f9b into aws:master Oct 15, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants