-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry(amazonq): Adding cwsprChatProgrammingLanguage parameter to insertAtCursor and CopyAtClipboard events #5768
Conversation
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
packages/core/src/codewhispererChat/controllers/chat/messenger/messenger.ts
Outdated
Show resolved
Hide resolved
…d added test cases for this function
@@ -582,7 +587,8 @@ export const createMynahUI = ( | |||
eventId, | |||
codeBlockIndex, | |||
totalCodeBlocks, | |||
messageUserIntentMap.get(messageId) ?? undefined | |||
responseMetadata.get(messageId)?.[0] ?? undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add these to ViewDiff
and AcceptDiff
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that can be in different PR as these two are unavailable for Generate Tests(Beta)
.
@ivikash Correct me on this!
use |
Thanks for upstreaming the metric to common. The build is failing because the old local metric still exists and overrides the common one. You need to delete it (in this PR):
|
Problem
interactWithMessage
is missingcwsprChatProgrammingLanguage
parameter which helps to understand the language of generated code.Solution
cwsprChatProgrammingLanguage
parameter for insertAtCursor and CopyAtClipboard events.extractCodeBlockLanguage
function as current UTG Sync API sends python and java in the first chunk of generated code but thats the not case for other languages. To counter this, I am checking entire response for generated code language and emitting those metrics.cwsprChatProgrammingLanguage
in commons package: telemetry: Adding cwsprChatProgrammingLanguage aws-toolkit-common#883cwsprChatHasProjectContext and cwsprChatTotalCodeBlocks
in in commons package: telemetry: cwsprChatHasProjectContext and cwsprChatTotalCodeBlocks aws-toolkit-common#884License: I confirm that my contribution is made under the terms of the Apache 2.0 license.