Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cwl): initialize tailLogGroup command. starts stream and prints logEvents to textDocument #5790

Open
wants to merge 2 commits into
base: feature/cwltail
Choose a base branch
from

Conversation

keeganirby
Copy link

@keeganirby keeganirby commented Oct 15, 2024

Problem

TailLogGroup currently is just logging the Users WizardResponse. It does not start a LiveTail stream or print results to the VSCode editor

Solution

  • Creates a LiveTailSession with the input params from the TailLogGroupWizard
  • Registers the LiveTailSession in the LiveTailSessionRegistry
  • Iterates the Response Stream and prints new LogEvents to a TextDocument
  • If there are no open tabs for a given session's TextDocument, the stream will be closed by triggering its AbortController and disposing its client.

We will use a new URI Scheme for LiveTail text documents so we can identify a LiveTail session vs a Cloudwatch SearchLogGroup/ViewLogStream document. In the future, we will register LiveTail specific CodeLenses that depend upon this URI scheme. Defining a new URI scheme for a Text Document requires a Document Provider. In this use case, it is empty given that the response handling that writes to the document lives within the TailLogGroup command itself.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keeganirby keeganirby requested a review from a team as a code owner October 15, 2024 23:33
Copy link

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Copy link

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@keeganirby
Copy link
Author

Spoke with Josh about this during the initial PR: will add a Changelog when the feature branch is complete and ready to merge to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant