Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attributes thread safety issue #73

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. attributes thread safety issue

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane July 18, 2024 15:14
@zhu-xiaowei zhu-xiaowei self-assigned this Jul 18, 2024
@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Jul 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (3ad7ee6) to head (86c9a95).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   96.91%   96.90%   -0.02%     
==========================================
  Files          35       35              
  Lines        1686     1711      +25     
==========================================
+ Hits         1634     1658      +24     
- Misses         52       53       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit bd3a062 into main Jul 19, 2024
6 checks passed
@zxkane zxkane deleted the fix-thread-safety-attributes branch July 19, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants