Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sorting highlights #38

Merged
merged 1 commit into from
Jul 28, 2024
Merged

feat: sorting highlights #38

merged 1 commit into from
Jul 28, 2024

Conversation

bandantonio
Copy link
Owner

Description

This update includes:

  • Add 5 sorting criteria for highlights
  • Add basic tests
  • Refactor tests to support sorting
  • Update documentation with sorting criteria settings and examples

Fixes #12

Checklist

  • I accept the Code of Conduct
  • I have performed a self-review of my code for consistency and potential leftover debug logs, commented out code, etc.
  • I have added tests that prove that my feature works or that the fix is effective
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if necessary)
  • I confirm that this PR DOESN'T change the plugin's version either in the manifest.json or package.json files
  • I have checked that my commit messages are descriptive and follow the Conventional Commits standard
  • I have enabled the checkbox to allow maintainer edits so the branch can be updated for a merge.

This update includes:
- Add 5 sorting criteria for highlights
- Add basic tests
- Refactor tests to support sorting
- Update documentation with sorting criteria settings and examples
@bandantonio bandantonio added the enhancement New feature or request label Jul 28, 2024
@bandantonio bandantonio self-assigned this Jul 28, 2024
@bandantonio bandantonio merged commit 2f91821 into master Jul 28, 2024
7 checks passed
bandantonio added a commit that referenced this pull request Jul 29, 2024
This update includes:
- Add 5 sorting criteria for highlights
- Add basic tests
- Refactor tests to support sorting
- Update documentation with sorting criteria settings and examples
@bandantonio bandantonio deleted the feat/order-highlights branch July 29, 2024 19:17
@bandantonio bandantonio added this to the ✅ 1.4.0 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Ordering Highlights
1 participant