Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor book import logic to be more consistent and user-friendly #43

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

bandantonio
Copy link
Owner

Description

This update includes:

  • Refactor of single book import logic that does not overwrite existing highlights
  • Dialog box to confirm overwrite of existing book highlight(s) for cases when backups are disabled
  • Documentation describing the updated behavior
  • Updated tests

Fixes #34

Checklist

  • I accept the Code of Conduct
  • I have performed a self-review of my code for consistency and potential leftover debug logs, commented out code, etc.
  • I have added tests that prove that my feature works or that the fix is effective
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly (if necessary)
  • I confirm that this PR DOESN'T change the plugin's version either in the manifest.json or package.json files
  • I have checked that my commit messages are descriptive and follow the Conventional Commits standard
  • I have enabled the checkbox to allow maintainer edits so the branch can be updated for a merge.

This update includes:
- Refactor of single book import logic that does not overwrite existing highlights
- Dialog box to confirm overwrite of existing book highlight(s) for cases when backups are disabled
- Documentation describing the updated behavior
- Updated tests
@bandantonio bandantonio force-pushed the feat/refactor-single-book-import branch from dd6ff42 to f65c9a4 Compare August 10, 2024 11:13
@bandantonio bandantonio added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 10, 2024
@bandantonio bandantonio added this to the ⏳ 1.5.0 milestone Aug 10, 2024
@bandantonio bandantonio merged commit 8424f57 into master Aug 10, 2024
8 checks passed
bandantonio added a commit that referenced this pull request Aug 10, 2024
…dly (#43)

This update includes:
- Refactor of single book import logic that does not overwrite existing highlights
- Dialog box to confirm overwrite of existing book highlight(s) for cases when backups are disabled
- Documentation describing the updated behavior
- Updated tests
@bandantonio bandantonio deleted the feat/refactor-single-book-import branch August 10, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

[Enhancement]: When backups are disabled, content overwrite during subsequent imports is not obvious
1 participant