feat(chain,wallet)!: rm ConfirmationTime
#1643
Open
+179
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rm `ConfirmationTime` because it is essentially the same thing as `ChainPosition<ConfirmationBlockTime>` without the block hash. We also impl `serde::Deserialize` and `serde::Serialize` for `ChainPosition`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ConfirmationTime, and favorsChainPosition<ConfirmationBlockTime>instead. The only difference between these two structures is thatChainPosition<ConfirmationBlockTime>contains an additionalBlockHash. Additionally,ConfirmationTimewas not used in many places. It was mainly for displaying information inbdk_wallet::Wallet.We also impl
serde::Deserializeandserde::SerializeforChainPosition.Notes to the reviewers
Changelog notice
bdk_chain::ConfirmationTime. UseChainPosition<ConfirmationBlockTime>in place.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing