change the docker harness to be dind instead of dood #181
+241
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
docker-harness-2
branch
from
cd7f5e8
to
54a7669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors the
imagetest_harness_dockerto be a truer docker-in-docker sandbox, instead of the existing docker-out-of-docker that it is today.this should make it feel a lot more "native", and doesn't share the same footguns with the dood approach. this also makes things more portable for the future state where we run sandboxes on k8s.
the one downside here is that registry mirroring is not supported. this makes it a blocker for the local development path where a local registry needs to be used