Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/screenshot #311

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Feat/screenshot #311

merged 8 commits into from
Aug 23, 2023

Conversation

elmarsan
Copy link
Contributor

@elmarsan elmarsan commented May 24, 2023 •
edited
Loading

Example

demo

Tape

Output screenshot.gif

Set Margin 30
Set MarginFill blue.jpg
Set WindowBar Rings
Set WindowBar Colorful
Set WindowBarSize 40
Set BorderRadius 10
Set FontSize 32


Type "We love screenshots!"

Screenshot demo.png

Sleep 1s

@maaslalani
Copy link
Contributor

This looks quite incredible @elmarsan!!!

@elmarsan
Copy link
Contributor Author

@maaslalani conflicts solved

caarlos0
caarlos0 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this!

@maaslalani
Copy link
Contributor

Thanks @elmarsan, this looks so great!

@maaslalani
Copy link
Contributor

Hey @elmarsan, when testing this I notice the mask.png and bar.png stay lingering. Are you able to reproduce this as well? Make sure you use a tape file that uses BorderRadius and WindowBar.

@elmarsan
Copy link
Contributor Author

Hey @elmarsan, when testing this I notice the mask.png and bar.png stay lingering. Are you able to reproduce this as well? Make sure you use a tape file that uses BorderRadius and WindowBar.

Good spot @maaslalani , I've fixed.

@elmarsan
Copy link
Contributor Author

@maaslalani is everything ok?

maaslalani
maaslalani approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@maaslalani maaslalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all the hard work @elmarsan!

@maaslalani maaslalani merged commit eeb6058 into charmbracelet:main Aug 23, 2023
7 checks passed
@maaslalani maaslalani deleted the feat/screenshot branch August 23, 2023 19:04
@maaslalani maaslalani mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

@maaslalani maaslalani maaslalani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmarsan @maaslalani @caarlos0