bugfix: issue 11801 #11849
bugfix: issue 11801 #11849
Conversation
| const options = this.options.setContext(this.getContext()); | ||
| const active = this._active; | ||
| let properties; | ||
| let tooltipItems = []; | ||
|
|
||
| if (!active.length) { | ||
| if (!active.length || !inChartArea) { |
There was a problem hiding this comment.
It seems that this behavior was added intentionally and is not a bug when I look at the code and the pr where this got introduced.
I will look at this later to see if this might break any implementations that rely on that behavior
There was a problem hiding this comment.
Thanks for the feedback.
Correct me if I'm wrong, from my understanding, the !active.length is added to make sure the chart can be interactive even when the cursor is out of it (hovering over the legend and high light the corresponding data in the chart).
Adding the extra check will only effect the visibility of the tooltip in this scenario.
There was a problem hiding this comment.
Hi @LeeLenaleee, do you think this is a proper change or do you have any further comments on this?
There was a problem hiding this comment.
Hi, I tested the changes, what you said is correct, this does still work with externally calling code to setActiveElements. Although the name is kind of misleading in those cases. Since the bool is called inChartArea, but when you use setActiveElements you are not in the chart area.
Also this change seems to introduce a new bug. When you move your mouse to the legend quickly and return to the same slice the hover does not trigger anymore
There was a problem hiding this comment.
Thanks @LeeLenaleee , I tested it and tried to fix that, but looks like it's not a simple change. I will change this PR to draft and work on this continuously.
Signed-off-by: Saber Sun <[email protected]>
kayhern
force-pushed
the
bugfix/issue-11801-tooltip-visible-on-legend-hover
branch
from
5f1d470
to
66a5204
Compare
Add some extra check to make sure the tooltip be hidden while cursor moving outside of the chart. This is to fix the issue #11801