-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App router migration new relic configuration #1086
Open
boodland
wants to merge
32
commits into
chaynHQ:next-js-migration
Choose a base branch
from
boodland:app-router-migration-new-relic-configuration
base: next-js-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
App router migration new relic configuration #1086
boodland
wants to merge
32
commits into
chaynHQ:next-js-migration
from
boodland:app-router-migration-new-relic-configuration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@boodland is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
@annarhughes This PR needs to point to app-router-migration branch once #1085 is merged |
boodland
force-pushed
the
app-router-migration-new-relic-configuration
branch
from
August 20, 2024 08:06
c900116
to
7e53126
Compare
@eleanorreem, @annarhughes I have just changed the base branch, have a look when possible. Thanks |
…tion-new-relic-configuration
…tion-new-relic-configuration
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Add google tag manager to root layout * Change strategy as worker is experimental and is not including the script * Move gtm to body as next is including it in head properly * Add comment to tackle in the future * Move gtm script from _document to _app
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Use script tag and set id * Add rollbar script to root layout * Make it beforeInteractive so it is included in the head * Move to _app as next/script is not working in _document
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Move primary color to a constant so can be used in a server component (root layout) * Create rootMetadata * Fix format * Add metadata to root layout --------- Co-authored-by: eleanorreem <[email protected]>
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Make error boundary client component * Add ErrorBoundary component to root layout * Create app router error route test page --------- Co-authored-by: eleanorreem <[email protected]>
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Create theme registry component * Add ThemeRegistry to root layout * Make theme client component * Install mui for app router --------- Co-authored-by: eleanorreem <[email protected]>
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Create Analytics component * Add analytics to root layout * Update layout.tsx --------- Co-authored-by: eleanorreem <[email protected]>
eleanorreem
force-pushed
the
next-js-migration
branch
from
October 2, 2024 13:21
db8dd34
to
cd3370c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Children PR for the progressive migration of _app.tsx and _document.tsx within the Root Layout
Issue link / number:
#1083
What changes did you make?
Created new relic configuration
Added new relic configuration to root layout
Why did you make the changes?
In order to be able to have new relic within app router
Did you run tests?
Yes
Navigate to http://localhost:3000/public-route-test to check that the head nr-browser-agent and body scripts are added properly