App router migration rollbar script #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boodland is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eleanorreem
approved these changes
Sep 20, 2024
eleanorreem
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add basic Root Layout * Add metadata * Add reference included by next * Add comment to explain the default meta tags * Add public testing page to check the migration * Remove non required file * Use script tag and set id * Add rollbar script to root layout * Make it beforeInteractive so it is included in the head * Move to _app as next/script is not working in _document
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#1083
What changes did you make?
Used Script nextjs tag
Set script strategy to beforeInteractive
Added rollbar configuration to root layout
Moved Script from _document to _app as seems to be an outdated pages router documentation bug see:
https://stackoverflow.com/questions/73813720/next-script-does-not-work-inside-document-js-file-nextjs
https://nextjs.org/docs/pages/api-reference/components/script#beforeinteractive
This documentation seems also wrong as next/script is not working on _document
https://nextjs.org/docs/messages/no-script-in-document
The following error is no longer triggered
https://nextjs.org/docs/messages/no-before-interactive-script-outside-document
Now the script is loaded in both pages and app router
Why did you make the changes?
In order to be able to have google tag manager within app router
Did you run tests?
Yes
Navigate to http://localhost:3000/ to check that the head rollbar script is added properly
Navigate to http://localhost:3000/public-route-test to check that the head rollbar script is added properly