Skip to content

Commit

Permalink
[TST] Move clippy into the lint job (#2886)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Moves clippy into its own job so that we don't block tests. It is good
to be able to run these separately.
- Unifies the rust lint jobs into the lint action, where `cargo fmt` was
already running.
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
  • Loading branch information
HammadB authored Oct 1, 2024
1 parent 52ab61b commit 9a46096
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/_rust-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
uses: actions/checkout@v3
- name: Setup
uses: ./.github/actions/rust
- name: Clippy
run: cargo clippy --all-targets --all-features --keep-going -- -D warnings
- name: Build
run: cargo build --verbose
- name: Test
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ jobs:
- name: Install pre-commit
shell: bash
run: python -m pip install -r requirements_dev.txt
- name: Setup Rust
uses: ./.github/actions/rust
- name: Run pre-commit
shell: bash
run: |
Expand All @@ -132,9 +134,13 @@ jobs:
pre-commit run --all-files flake8
pre-commit run --all-files prettier
pre-commit run --all-files check-yaml
continue-on-error: true
- name: Cargo fmt check
shell: bash
run: cargo fmt -- --check
continue-on-error: true
- name: Clippy
run: cargo clippy --all-targets --all-features --keep-going -- -D warnings

# This job exists for our branch protection rule.
# We want to require status checks to pass before merging, but the set of
Expand Down

0 comments on commit 9a46096

Please sign in to comment.