Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Disk and memory-backed cache with Foyer 0.10. #2890

Merged
merged 11 commits into from
Oct 4, 2024
Merged

[ENH] Disk and memory-backed cache with Foyer 0.10. #2890

merged 11 commits into from
Oct 4, 2024

Commits on Oct 1, 2024

  1. [ENH] Disk and memory-backed cache with Foyer 0.10. 

    The lfu/lru/weighted_lfu caches didn't initialize a hybrid cache.  This
PR rewrites the chroma_cache crate to hide implementation details of the
cache as much as possible.  Noteworthy callouts from this PR:

- We don't currently support cleaning up of tempfiles evicted from
  cache.  This is status-quo.
- cops-disk-cache-config-writer and cops-memory-cache-config-writer
  provide command-line arguments to generate the YAML for the Foyer
  cache.
- Cache<K, V> is a trait.  PersistentCache<K, V> allows for requiring
  persistence.  All PersistentCache<K, V> can be cast to Cache<K, V>.
    @rescrv
    rescrv committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0db390e View commit details
    Browse the repository at this point in the history

  2. self-review cleanup

    @rescrv
    rescrv committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a1b7cf3 View commit details
    Browse the repository at this point in the history

  3. be helpful on cache configuration errors

    @rescrv
    rescrv committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bb66221 View commit details
    Browse the repository at this point in the history

  4. add NOP cache and a nop enum that aliases lru, lfu, and weighted_lfu

    @rescrv
    rescrv committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ef8ec62 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. memory for hnsw cache config

    @rescrv
    rescrv committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6c89b15 View commit details
    Browse the repository at this point in the history

  2. build the memory cache in from_config

    @rescrv
    rescrv committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    34e6f94 View commit details
    Browse the repository at this point in the history

  3. backwards compatibility with the old config

    @rescrv
    rescrv committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    19c3207 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. ensure that Block can work with cache too, to eliminate to/from bytes

    @rescrv
    rescrv committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4783d70 View commit details
    Browse the repository at this point in the history

  2. Incorporate Hammad's suggestion to put ser/de on the block

    @rescrv
    rescrv committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    26c06dd View commit details
    Browse the repository at this point in the history

  3. comments

    @rescrv
    rescrv committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8554615 View commit details
    Browse the repository at this point in the history

  4. cargo clippy

    @rescrv
    rescrv committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e060251 View commit details
    Browse the repository at this point in the history