Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] RateLimitEnforcer abstract class #2898

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[ENH] RateLimitEnforcer abstract class #2898

wants to merge 3 commits into from
+88 −158

Conversation

drewkim
Copy link
Contributor

@drewkim drewkim commented Oct 3, 2024 •
edited
Loading

Description of changes

  • New functionality
    • Removes the old rate limiting system and creates a new RateLimitEnforcer abstract class that can be implemented to rate limit requests.

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

@drewkim Graphite App
Copy link
Contributor Author

drewkim commented Oct 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @drewkim and the rest of your teammates on Graphite Graphite

@drewkim drewkim changed the title Remove old rate limiting and put in new abstract class/error [ENH] RateLimitEnforcer abstract class Oct 3, 2024
@drewkim drewkim marked this pull request as ready for review October 3, 2024 22:27
@drewkim drewkim marked this pull request as draft October 3, 2024 22:27
@drewkim drewkim force-pushed the drew/ratelimitenforcer_abstract_class branch from baac543 to cde4f58 Compare October 5, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drewkim