Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Implement utility functions to instantiate segment #2902

Open
wants to merge 1 commit into
base: 10-01-_tst_implement_utility_functions_to_instantiate_blockfile_provider
Choose a base branch
from

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Oct 4, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Change the visibility in the worker crate in order to run benchmark
  • New functionality
    • Implement utility functions to compact logs into segments for benchmark

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Sicheng-Pan and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review October 4, 2024 20:27
@Sicheng-Pan Sicheng-Pan force-pushed the 10-01-_tst_implement_utility_functions_to_instantiate_blockfile_provider branch from 4626c4d to 918b366 Compare October 4, 2024 20:33
@Sicheng-Pan Sicheng-Pan force-pushed the 10-03-_tst_implement_test_utilities branch from cde5089 to badfecf Compare October 4, 2024 20:33
@Sicheng-Pan Sicheng-Pan force-pushed the 10-01-_tst_implement_utility_functions_to_instantiate_blockfile_provider branch 2 times, most recently from 03f24a4 to 35a50e8 Compare October 4, 2024 21:57
@Sicheng-Pan Sicheng-Pan force-pushed the 10-03-_tst_implement_test_utilities branch from badfecf to 4c8408c Compare October 4, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant