Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using/testing EOLed 3.6 and 3.7, use 3.9 for linting (3.8 EOLs soon) #91

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

yarikoptic
Copy link
Member

No description provided.

@yarikoptic yarikoptic requested a review from jwodder May 31, 2024 18:52
Copy link
Member

@jwodder jwodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to:

  • Update python_requires in setup.cfg
  • Remove pypy-3.7 in test.yml
  • Remove 3.7 and pypy-3.7 in benchmark.yml

@yarikoptic
Copy link
Member Author

any clue on how to address

asv run --show-stderr --python "$ASV_PYTHON" HEAD^-1
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/con/fscacher/actions/runs/9323025437/job/25665310581?pr=91#step:14:3).11.9/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.9/x6[4](https://github.com/con/fscacher/actions/runs/9323025437/job/25665310581?pr=91#step:14:4)/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x[6](https://github.com/con/fscacher/actions/runs/9323025437/job/25665310581?pr=91#step:14:6)4
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib
    FSCACHER_BENCH_TMPDIRS: .:/tmp/nfs:/tmp/vfat
    ASV_PYTHON: 3.11
Couldn't load asv.plugins._mamba_helpers because
No module named 'libmambapy'

I thought I found a workaround 6a4a330 but seems not

@jwodder
Copy link
Member

jwodder commented May 31, 2024

@yarikoptic I think the simplest option for now is to restrict asv to <0.6.2.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (6ccd52f) to head (c2a0d86).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files           4        4           
  Lines         520      520           
  Branches       82       82           
=======================================
  Hits          478      478           
  Misses         25       25           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

What do we do about
Screenshot_20240531-175159
?

I feel like we were in similar situation somewhere else.
If recall fix, just push please

@yarikoptic
Copy link
Member Author

Woohoo, thanks!

@yarikoptic yarikoptic merged commit 3a0e5b5 into master Jun 1, 2024
62 checks passed
@yarikoptic yarikoptic deleted the enh-updates branch June 1, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants