Chore/vuln deps image focal point #9035
Conversation
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
david-shibley-contentful
force-pushed
the
chore/vuln-deps-image-focal-point
branch
from
b475682
to
64f4a34
Compare
| "homepage": "." | ||
| "homepage": ".", | ||
| "optionalDependencies": { | ||
| "@rollup/rollup-linux-x64-gnu": "4.9.5" |
There was a problem hiding this comment.
Curious about this too since I've been having some weird rollup issues with optimizely and wondering if you were running into rollup stuff that this fixed?
There was a problem hiding this comment.
yeah I was, this fixed it :-)
There was a problem hiding this comment.
the error I was getting that this resolved was
Cannot find module @rollup/rollup-linux-x64-gnu
| @@ -143,7 +143,7 @@ export class AppView extends Component { | |||
| <> | |||
| <div className={styles.background} /> | |||
| <div className={styles.body}> | |||
| <Typography> | |||
| <React.Fragment> | |||
There was a problem hiding this comment.
I was thinking that React.Fragment is an old method that was replaced with just the empty brackets <></> so we probably don't need this? I think Typography was basically deprecated in Forma for the same reason, that we just use empty fragment tags now.
There was a problem hiding this comment.
Can change 👍
| @@ -1,9 +1,8 @@ | |||
| import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import ReactDOM from 'react-dom'; | |||
| import { Note } from '@contentful/forma-36-react-components'; | |||
| import { Note } from '@contentful/f36-components'; | |||
There was a problem hiding this comment.
I think one of the updates with note was the switch to use a generic variant prop instead of the component specific noteType prop. I didn't see that change in here and I'm figuring that's because this app isn't in typescript and so it didn't yell about it? But I wonder if the note's variant is actually being respected since we're passing in a deprecated prop.
There was a problem hiding this comment.
good to know! will fix
Purpose
EXT-5794
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment