Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(math): Backport of pull requests #17352 and #18214 to feature/v.0.47.x-ics-lsm branch #19293

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix(math): Backport of pull requests #17352 and #18214 to feature/v.0.47.x-ics-lsm branch #19293

merged 1 commit into from
Jan 31, 2024

Conversation

dusan-maksimovic
Copy link

@dusan-maksimovic dusan-maksimovic commented Jan 30, 2024 •
edited
Loading

Description

Backporting PRs #17352 and #18214: Defend NewIntFromBigInt and NewUIntFromBigInt argument mutation.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@dusan-maksimovic
Ensure that modifying the argument to NewUIntFromBigInt and `NewInt…
813f92a 
…FromBigInt` doesn't mutate the returned value
@dusan-maksimovic dusan-maksimovic requested a review from a team as a code owner January 30, 2024 14:16
@dusan-maksimovic dusan-maksimovic changed the title Backport of pull requests #17352 and #18214 fix(x/gov): Backport of pull requests #17352 and #18214 to feature/v.0.47.x-ics-lsm branch Jan 30, 2024
@dusan-maksimovic dusan-maksimovic marked this pull request as draft January 30, 2024 14:31
@dusan-maksimovic dusan-maksimovic changed the title fix(x/gov): Backport of pull requests #17352 and #18214 to feature/v.0.47.x-ics-lsm branch fix(math): Backport of pull requests #17352 and #18214 to feature/v.0.47.x-ics-lsm branch Jan 30, 2024
@dusan-maksimovic dusan-maksimovic marked this pull request as ready for review January 31, 2024 07:16
mpoke
mpoke approved these changes Jan 31, 2024
View reviewed changes
Copy link

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @dusan-maksimovic

@mpoke mpoke merged commit 17d5f73 into cosmos:feature/v0.47.x-ics-lsm Jan 31, 2024
24 of 29 checks passed
mattverse pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Feb 6, 2024
@dusan-maksimovic @mattverse
fix(math): Backport of pull requests cosmos#17352 and cosmos#18214 to…
856c280 
… feature/v.0.47.x-ics-lsm branch (cosmos#19293)
@mattverse mattverse mentioned this pull request Feb 6, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpoke mpoke mpoke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dusan-maksimovic @mpoke