Fixing setting crash #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since multiple instances of the app runs at once screensaver defaults are needed rather than just the typical user defaults. This fixes the issue with the screensaver hanging when running on two monitors.
…'t get larger than the preview window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause:
The system preferences crash is caused by the square size being too big for the preview screen, causing the app to crash when modifying the size in system preferences.
Solution:
using the isPreview call in the MazeScene to always set the square size to 1.
Tradeoffs:
only downside is that it doesn't scale properly, could figure out the max square size for the preview screen and use division to calculate it like before. This is more of a rudimentary fix but it prevents crashes.
Also a gitignore should probably be added for these files and folders:
Not sure if I can do that in a PR or if the repo owner can only edit that.