🧪 mock get transaction receipt #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsbot
requested changes
May 12, 2023
| effectiveGasPrice: tinyBig(mockReceiptResponse.effectiveGasPrice), | ||
| gasUsed: tinyBig(mockReceiptResponse.gasUsed), | ||
| status: Number(hexToDecimal(mockReceiptResponse.status)), | ||
| logs: mockReceiptResponse.logs.map(({ removed, ...log }) => ({ |
There was a problem hiding this comment.
Sleek and interesting, but I have no idea what this does.
Probably too tricky to throw into a JSON object like this. Perhaps we can name this a helpful const like "mockLogsWithoutWhatever" above the mockReceipt initialization then use it inside here?
My main misunderstanding is why we need to remove anything from the logs using this restructuring and a well-named variable above might be helpful
There was a problem hiding this comment.
I was trying to clean the log without using the cleanLog function, but I see how this confusing. I will just use the helper and add cleanLog to the list of helpers to test #228.
dawsbot
reviewed
May 12, 2023
| (log) => omit(log, ['id', 'removed'] as any) as any, | ||
| ); | ||
| const mockBlocksBetween = 10; | ||
| const mockReceiptResponse = { |
There was a problem hiding this comment.
WOW, this will be so helpful to get merged. Big objects 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dawsbot Here is another one.
I used destructuring here to remove an element from the copy which I thought was pretty sick 🧼
https://github.com/jtfirek/essential-eth/blob/5840d0255a5383f2d69a29131f6d2a25e3b34d15/src/providers/test/json-rpc-provider/get-transaction-receipt.test.ts#L64