vets-api/v0.0.1418

Release 0.0.1418 ami-0470ca4f5ef4c16bd

d1d723e handle nils in appt failures (#12481)

85d7aa1 handle nils in appt failures (#12485)

ecdd161 Require pdf filler for FSR (#12478)

45d5818 Mobile: Relocate logging of sso information to controller concern (#12486)

• Add logging for contact information updates

• Add more logging locations and start tweaking tests

• Add expiration to test

• Move logging and tests to profile base controller

• Please rubocop

• Remove duplicate logging

• Remove duplicate logging

• Move files back

• Remove unnecessary file

• Make rubocop happy

• Relocate sso logging logic to a controller concern and include that in payment information

• Zeitwerk fix

9eee7cc Bdex/56794: refactor Lighthouse Veteran Verification API service (#12467)

• bdex/56794:

• make rated_disability api provider configurable per vets-website application

• bdex/56794: run rubocop

• bdex/56794: change to user

• bdex/56794: make service configuration more... configurable

• remove local unit test credentials

• bdex/56794: send correct number of params

• bdex/56794: refactor for aud_claim_url configuration

so configurable now

• bdex/56794: use correct settings and variables

f736c49 Forms api - 21 4142 fixups (#12490)

• fixup mappings and add min test

• allow for other relationship value

32b6614 Prevent redis cache if data is nil (#12494)

b6e3aab [department-of-veterans-affairs/va-virtual-agent#873] Adds logging fo (#12489)

• [department-of-veterans-affairs/va-virtual-agent#873] Adds logging for appeals in staging

• [department-of-veterans-affairs/va-virtual-agent#873] Fixes linting

• [department-of-veterans-affairs/va-virtual-agent#873] More linting fixes

b65d0bf Revert "Prevent redis cache if data is nil (#12494)" (#12495)

This reverts commit 32b6614.

vets-api/v0.0.1417

Release 0.0.1417 ami-01c12a72834a52548

feaf6b9 Api 25622 tracked item status (#12451)

f1054bc Flipper auto refresh (#11897)

• first attempt

• creates refresh on mount + 4 min interval

badd7f1 5198 handle partial appointments response (#12438)

• passed failures error to controller

• updated meta to include errors if avail

• crested cassette for partial errors

• updated cassette

• added test for partial errors in spec

• updated api docs with example for partial appointments

• rerendered docs

• added statsd logging for partials

• fixed controller

• v2 specs fix

• updated partial error cassette

• fixed appointments cache and corresponding specs

• updated appointments v2 specs with count

• added description

• added multi_status

• update partial error method

• changed precaching based on whether failures are present

• fixed pre_cache_appointments job

• re-rendered docs

• fixed comment

• re-rendered docs

bce8975 Add logging for contact information updates (#12398)

• Add logging for contact information updates

• Add more logging locations and start tweaking tests

• Add expiration to test

• Move logging and tests to profile base controller

• Please rubocop

• Remove duplicate logging

• Remove duplicate logging

• Move files back

• Remove unnecessary file

• Make rubocop happy

f640fb3 Forms api - Mask all potential PII from error message (#12471)

• redact ssn and dob

• remove user-entered info from errors

• lint

• cleanup incidentals

• Add tests for scrubbing pii

4c991c1 API-25979-post-schema-docs (#12462)

• Remove schema endpoint. Adds schema to post endpoint. Changes description.

• Rubocop

• WIP

• Modifies request.json and example.json

• Adds schema to 200 response

• Modifies example and request body for 526

• updates example and request

• removes unused

• v2 changes

• order to match form

• updates OAS

• update to string

---

Co-authored-by: FonzMP [email protected]

353c867 Add require so PdfFill module is found (#12479)

Co-authored-by: michelpmcdonald michel.mcdonald@adhocteam

vets-api/v0.0.1416

Release 0.0.1416 ami-099c01285f6b42eca

a1c0413 Additional Protection (#12461)

• Additional Protection

• fixing

158b68e Adding controller / route for EVSS benefits claims (#12469)

• Adding controller / route for EVSS benefits claims

• Returning the full JSON for a claim

a73826e 56975 Caching mobilePhone for travel claims notification (#12455)

• 56975 Caching mobilePhone for travel claims notification

• Adding tests for payload without mobilephone

• Removing no mobile test data

---

Co-authored-by: kanchanasuriya [email protected]

16732a1 5246 rx mapping (#12454)

• 5246: correct rx status mappings

13ac80b VACMS-13117 Remove BTSSS login widget flag (#12468)

7095b38 adds require string_helpers (#12470)

vets-api/v0.0.1415

Release 0.0.1415 ami-0ad062e9b37fc18f4

5eaf9ed 5284 filter doc 27 (#12447)

522556d Removed logging (#12463)

• Removed logging

• linting

df2e996 Add extra build args to docker build process (#12466)

Co-authored-by: Curt Bonade [email protected]

fa42e72 Fix capitalizaton (#12464)

• Fix capitalizaton

• updated docs to reflect change

• Non-binary fix

a40b2ac Migrate 1010ez disability rating code to BGS (#12442)

• remove prefill compensation type

• find rating data method

• add rating info method to hca controller

• convert disability rating to integer

• add swagger

• lint

53cb62d API-25980: Fix Benefits Intake 'Status Summary' Slack Alert (#12458)

• API-25980: Update Slack summary notification so that it isn't tied to the Sidekiq schedule

• API-25980: Update Slack alert header

• API-25980: Remove vba_documents setting no longer in use

• API-25980: Update specs after making summary notification generate on every job run

e75f288 API-25790-closed-phase-dates (#12448)

• Removes get_completed_phase_number_from_phase_details method, and else clause in get_bgs_phase_completed_dates

• refactors method

• Update claims_controller.rb

Removes comments

45f5936 API-25814: Update api_version to "V0" for Segmented Appeals APIs (#12443)

• API-25814: Update api_version to 'V0' for all segmented Appeals APIs

• API-25814: Resolve rubocop offenses

• API-25814: Rename scope

• API-25814: Add specs for updates to HlrStatus concern

• API-25814: Update NOD v2 schema to use new constant

e0792eb Add job class to allow for one time in progress reminders (#12459)

03295e5 Mocked auth views (#12444)

• mocked_auth ERB files

• 53352 - moves mocked_users controller to credential; fix templating + routes + credential/service

• updates authorize callback to include state + encoded_credential

• updates mocked_auth routes.rb; adds JS to credential#index

• updates verbage in template; fixes formatting in mock_auth/lib/credential/service

• updates specs for lib/credential/service_spec.rb

• changes mock_auth view to only show credential_payload

• adds validate_credential_list_params check + updates validate_index_params

• adds credential#index spec; adds resuce error json; fixes linting issue

• fix linting of rescue json vs html

• fix linting issue 2nd

• [53015] Updating mocked auth credential specs

---

Co-authored-by: Trevor Bosaw [email protected]

vets-api/v0.0.1414

Release 0.0.1414 ami-052c2edf28e001f9c

b815b4e [12423] Remove StatsD reset counters from initializers (#12426)

Co-authored-by: Trevor Bosaw [email protected]

5f5a351 add metadata business lines (#12270)

• API-24689: add metadata business lines

• fixed SC metadata naming to match standard we came up with

---

Co-authored-by: michelpmcdonald michel.mcdonald@adhocteam

de63928 56976 add mobile_phone method to TravelClaim RedisClient (#12456)

94dfa2e Removing spec functionality that was updating fixtures during tests (#12450)

Co-authored-by: Trevor Bosaw [email protected]

vets-api/v0.0.1413

Release 0.0.1413 ami-03af788cb11432aa4

95d60bd Remove original VHA FSR email (#12433)

• Initial logic to submit batch VHA jobs

• Remove original email send for VHA FSR

90e711a Include deduction code and resolution comment in FSR params (#12434)

77ce49d fix (#12441)

536f749 Added payload session (#12388)

• Added payload_seeion method that logs a user_id session completed time after deposit

• changed current_user[:email] to current_user[:identity] so the user_object is printed not just the email. fixed linting

• In def sso_cookie_content, I add session_uuid in the the file authentication_and_sso_concerns.rb. I created a spec for sso_logging_info in application_controller_spec.rb

• Added authentication components that allow logger access to the controller.

• Changed session_uuid to use object except string

abbca2d 4743: change mobile lighthouse letters client id to match new key (#12172)

Co-authored-by: Andrew Herzberg [email protected]

95ba197 VA-11593: Remove PPMS Remove Roced Unique ID feature (#12432)

4b68508 add logging (#12449)

• add logging

• fix

---

Co-authored-by: Andrew Herzberg [email protected]

313a508 Adding zip backup (#12445)

• Adding zip backup

• rubo

• making method 1 less line to appease rubocop

vets-api/v0.0.1412

Release 0.0.1412 ami-0435a44bca6760862

6b05356 Reenable merge to master image update in ECR for preview environments (#12431)

Co-authored-by: Curt Bonade [email protected]

cfb84c8 API-24681-526-schema-draft (#12400)

• Adds v2 526 schema - WIP

• Adds to disabilities

• Adds details for most sections

• Adds data type, and descriptions for most sections

• Moves v1 schemas into v1 folder, makes assoc changes. Adds routes for schemas. Adds rswag test for schema.

• Rubocop, and adds back commented out code in rswag test

• Disables rubocop Lint/MissingSuper

12d3741 Add Melissa Staging email address for testing (#12430)

32db7f7 - add an umbrella feature toggle for My VA (#12424)

experimental features

• updated description for an existing My VA toggle

fe30126 add logging (#12435)

cc3352e add decision_letter_sent field to claims and appeals overview (#12387)

7cc3845 Vfep 531 - fix 5490 spool file phone number order and school selection questions (#12402)

• fix tests after updating json-schema to include guardian

• modify school selection and update tests

• fix Gemfile.lock

• nokogiri fix

• fixes for school selection and phone numbers

• show mobile number before home number in spool files for all forms

• updated Gemfile.lock from master

---

Co-authored-by: nfstern02 [email protected]

c422cbc Adds back 526 docs (#12437)

bf56803 57042 Include code in TravelClaim Response when successful (#12436)

2579f14 API-25080: Generate Slack alert when Appeals PACT Act boolean field not enabled in Dev and Staging (#12440)

d21a0af Bdex/54508: intent to file get abstraction (#12427)

• Initial creation of common files between GET and POST endpoint migration work

• Correct response abstraction file name; Add remaining abstraction functions

• intent to file post abstraction

• fix flipper placements

• fix tests

• fixes to swagger_spec.rb

• rubocop fix

• unit test fix

---

Co-authored-by: mchae-nava [email protected]
Co-authored-by: Seth Darr [email protected]
Co-authored-by: Seth Darr [email protected]

vets-api/v0.0.1411

Release 0.0.1411 ami-022d1a456433b4962

0b0731c 55882 update travel claim controller to call worker (#12371)

9124523 API-25108 deprecate veteran confirmation (#12412)

• set deprecation and sunset headers for VC and updated openapi yml to indicate VC is deprecated

• removed extra emtpy line at end of method

b78b66a [52864] Add signature date to 5655 pdf (#12382)

• Add mapping for signature date

• Update test PDFs

634118b [55554] Use Sidekiq Batch to bulk upload VHA submissions (#12376)

• Initial logic to submit batch VHA jobs

• Add test for multiple vha station submission

2902208 API-24975 BGS healthchecks (#12399)

• Reenable bgs healthchecks for v1, add bgs healthchecks for v2

• Add comments preceding Rubocop directives

• Rubocop fixes

89e2239 Api 25719 current phase back (#12380)

• Fix phase type change indicator logic

• Add additional check to current_phase_back, add test and factory

• Rubocop fixes

• Refactor logic for clarity, reduce array vs hash tests

• Rubocop remove unnecessary class length disable

• Add back disable class length check

• Fix to handle single hash return from BGS

0923908 Adds logging for organic modal experiment (#12373)

• Adds logging for organic modal experiment

• Adjust statsd keys to remove tags

adf00c9 Remove enable_in_development key from Appeals feature flags (#12418)

c8379e9 Forms api - add 21-4142 mappings (#12405)

• initial files and mappings

• add new for files

• mappings for max payload

• order mappings

• add ability to stamp 21-4142

• cleanup stampers

• conditional substrings

• mapping updates

• update model with known metadata fixes

• update stamper to stamp preparer name as signature

• remove tests to shrink pr size, will add later

• add tests to form

3b27eda [12421] Remove unnecessary identity related statsd from initializers (#12422)

Co-authored-by: Trevor Bosaw [email protected]

e4641ae Add prefill config for 21-4142 (#12416)

• add prefill config for 21-4142

• undo formatting change

8fcd4f1 Fixing spec issue with loading certain files (#12429)

Co-authored-by: Trevor Bosaw [email protected]

74fe54a Fixing spec that was updating fixtures when run and causing file changes in Git (#12428)

Co-authored-by: Trevor Bosaw [email protected]

07ba8bc Add feature toggle for using LH as backing service (#12419)

f381a9f Update cron schedule for some VBADocuments jobs (#12417)

c32247b APT 25791 latestPhaseType values (#12420)

• Fix phase type change indicator logic

• Add additional check to current_phase_back, add test and factory

• Rubocop fixes

• Refactor logic for clarity, reduce array vs hash tests

• Rubocop remove unnecessary class length disable

• Add back disable class length check

• Fix to handle single hash return from BGS

• Updates to return correct phase type and handle mapping; updated tests, schema, swagger for same

vets-api/v0.0.1410

Release 0.0.1410 ami-0d3118b71dd1eca02

02e5a2d Set ssn to User#ssn if malformed in SubmitForm674Job. (#12410)

In #12379, I set up logging to catch if we were sending malformed SSNs in our vnp_person_create call to BGS. That work was predicated upon the assumption that when BGS returned a failed SQL statement with an SSN of "", BGS was redacted the actual SSN we sent over. After deploying this work, I learned that we were literally sending SSNs equal to the string "" to BGS.

The SSN we send originates from User#ssn, in BGS::DependentService. It is passed to SubmitForm686cJob, which makes a successful request to BGS (i.e. the SSN at this stage is a valid 9-digit SSN). That SSN is then passed to SubmitForm674Job; however, by the time we are sending it to BGS, it has transformed into the string "********". I have no idea why this is happening, even after spending several hours investigating. I'm going to continue that investigation, but in the meantime, in this PR, I'm going to try to "refresh" the ssn by calling User#ssn once again, if the SSN is malformed before we send it to BGS.

5e8df63 Update appeals_api rake tasks for new OAuth scopes (#12368)

• Update appeals_api rake tasks for new OAuth scopes

• Make rake task code slightly more readable

411bb76 Task update native doc (#12297)

• add redis to OSX getting started native doc

• update numbering for setup doc

---

Co-authored-by: Verdance Luke [email protected]

63cfaf0 Bdex/54161: Migrate eVSS calls to rated disabilities functionality (vets-api /rated_disabilities) (#12234)

• bdex/54076: start eVSS -> Lighthouse api provider interface

• bdex/54076: add rated disablity dto

• bdex/54076: start data transform layer

• incremental work

• cleanup

• revert gemfile.lock

• revert gemfile.lock again

• more cleanup

• more cleanup

• added super (thanks for asking)

• abstract class impersonation

• more cleanup

• unit tests + in progress work

• more adds

• bdex/54076: beef up rated disabilities api provider unit tests

• bdex/54076: change to symbol for shared_examples name

• fix linting errors

• added feature toggle for rated disabilities provider

• fix swagger_spec tests

• added bdex to CODEOWNERS

• modularize!

• revert modularization

• added LH veteran_verification endpoint infra

• added LH veteran_verification endpoint infra 2

• moved feature toggle to api factory

• incremental work on LH VV implementation

• more vv testing

• more incremental work

• changed rated_disabilities HTTP method to POST

added transform layer for lighthouse provider

• added factory method calls to in-progress controller

• cleanup

• revert whitespace

• whitespace removal

• rubocoping

• added configs to test.yml

• more api changes + unit test fixes

• form_profile_spec test fix

• changes in passing icn

• bdex/54161: remove space at the end of json generation

• bdex/54161: remove unnecessary variable declaration

• bdex/54161: fix rubocop offenses

• bdex/54161: fix auth token url path

• bdex/54161: disable lighthouse api provider for evss tests

• bdex/54161: fix service unit test

• bdex/54161: update test description wording

• bdex/54161: configurable timeout

• bdex/54161: test creating lh provider when feature is enabled

• bdex/54161: fix spelling errors

• bdex/54161: do not raise exception on Lighthouse error - simply log

• bdex/54161: use Rails.logger for service failure information

• bdex/54161: trim line length

• bdex/54161: transform LH "decision" to "SVCCONNCTED" or "NOTSVCCON"

• bdex/54161: rectify linting

• bdex/54161: add rated disability description text

• bdex/54161: reduce method line length

• bdex/54161: abstract decision_code transform for method line length

• bdex/54161: turn off lighthouse provider for evss service tests

• bdex/54161: rename request_body variable to auth_params

• does this dismiss reviews?

---

Co-authored-by: lightning [email protected]

f70df3d Update appeals insomnia config (#12393)

a57550d Disable Rails console autocomplete in deployed envs (#12411)

926b2c3 [12331] Refactor BGS Services to more clearly show what User model fields are being leveraged (#12332)

Co-authored-by: Trevor Bosaw [email protected]

4e4d670 Remove sign-in service stats from initializer (#12415)

vets-api/v0.0.1409

Release 0.0.1409 ami-054aab206f4f1d5b6

aba8097 Forms API: parse out characters that break json (#12404)

• parse out characters that break json

• fix comments