vets-api/v0.0.1398

Release 0.0.1398 ami-0e8a0e2f17048a743

767ec90 Fix badly anchored regex (#12315)

https://github.com/department-of-veterans-affairs/vets-api/security/code-scanning/88

2f6b595 RX log clean up (#12303)

vets-api/v0.0.1397

Release 0.0.1397 ami-0b92b9ce8e1fa0eab

72bbaf4 Update danger's ubunut version for Ruby 3.1.4 (#12307)

bba0d02 Lighthouse direct deposit (#12292)

• Add direct deposit service and specs

• Remove PUT specs to keep PR under 500 lines.

• Add comp and pen controller and specs

• Add controller tests and refactor code

• Remove unused methods from control_information class

• Update account_type validation logic to match on uppercase values

• Update payment_information mapping functionality

• Fix linting issue

• Condense multiple lighthouse policies into a single policy

• Fix authorized services spec

• Update Lighthouse direct deposit policy

• Update lighthouse direct deposit policy name

• Update lighthouse direct deposit policy name - take 2

• Update Gemfile.lock for vets_json_schema gem

• Update error handling, serialization, and specs

• Fix http status expectation

• Add error parsing to make error schemas consistent

• Resolve merge issue with payment_information

• Use configuration instead of perform for now

• Update spec description

552ce6e Upgrade Ruby to 3.2 (#12296)

• Upgrade Ruby to 3.2

• RuboCop: Correct Lint/RedundantRequireStatement

• Revert "Spec Fix: Mobile Claims and Appeals request spec"

This reverts commit 06477a66a9a119d42f68850415b42b346f3983ff.

It is no longer needed in Ruby 3.2.

vets-api/v0.0.1396

Release 0.0.1396 ami-0f59f672edde72c08

6c7dd5d API-24392: Remove test feature from VBADocuments enabled_features config (#12300)

• API-24392: Remove test feature from enabled_features config

6908b5a [12301] Removing Sidekiq DowntimeChecker middleware and using regular sidekiq retries instead (#12302)

Co-authored-by: Trevor Bosaw [email protected]

e042c37 Fixing non-retryable non-triggering of backup claim submissions (#12298)

• Attempting to fix issue with not sending backup submissions for failed 526 claims with non-retryable errors

• rubo cop

• rubocop, additional comments, adding protection against sending if there is already a backup submission ID present to prevent dups

c95e102 MHV-41341: download immunizations scaffolding complete (#12282)

d7bf6a4 55597 mocked auth data profiles (#12232)

• adds mocked authentication profiles route

• adds specs & updates with parsed email identifier

• restores master for db_seeds_development

• updates return format

• updates

• adds newline

• adds reader_spec

• adds mockdata_fetcher spec

• refactoring

• spec cleanups

• refactoring

• fixture updates

• updates mockdata lookup file validations

• refactors

• rubocop fix

91e0ec9 Update Ruby to 3.1.4 (CVE) (#12305)

• Upgrade to Ruby 3.1.4

• Use PR for ruby/setup-ruby GHA

02c39f9 GHA: Revert ruby/setup-ruby to @v1 (#12306)

vets-api/v0.0.1395

Release 0.0.1395 ami-0525a6f1c711d84cc

ec7ffd0 API-25265-tracked-items-attribute-names (#12279)

• API-25265-tracked-items-attribute-names; changes attribute name on the tracked items object

• Fixes casing on tracked_item: display_name

e72c681 Include MHV in organic experiment (#12195)

• Include MHV authentication in organic experiment

• Update flag to better reflect requirements

• Add service provider to json response

• Memoize service_name

• Change service_name to credential_type

164ca32 Omit contention text from RRD-to-MAS handoff tracking emails (#12288)

• Omit contention text from RRD-to-MAS handoff tracking emails

• Remove trailing blank line

a8dc46b Change vagov_info_token to JSON (#12161)

7d9444d API-24392: Add Feature Flag Monitoring Job for VBADocuments (#12256)

• API-24392: Add feature flag monitoring job for VBADocuments

• API-24392: Simplify since only DefaultNotification exists for now

• API-24392: Rename to

94dd1c6 Fixed spec fails (#12293)

77c3068 Add vsp environment and description text to ExpiryScanner job (#12289)

3a3bc46 Adds Daniel Sasser to admin user list; (#12291)

• Removes former user no longer on the project.

Co-authored-by: Daniel Sasser [email protected]

fd5b5ec Update Ruby to 3.1 (#12294)

• Upgrade to Ruby 3.1

• Fix boot error

See https://stackoverflow.com/questions/71191685/visit-psych-nodes-alias-unknown-alias-default-psychbadalias

• RuboCop: Auto correct Style/HashSyntax

Also corrects other Offenses which came up when correcting for HashSyntax:

• Style/IfUnlessModifier
• Layout/FirstArgumentIndentation
• Layout/FirstHashElementIndentation

• RuboCop: Auto correct Naming/BlockForwarding

• RuboCop: Auto correct Style/ArrayIntersect

• Spec Fix: Mobile Claims and Appeals request spec

ca4e64d Update flipper email for Adrian Rollett (#12295)

Updates flipper access for Adrian Rollett. (Newly an OCTO engineer)

vets-api/v0.0.1394

Release 0.0.1394 ami-0a9e0e32f7b20539f

509b017 Changes rescue (#12273)

01e59e1 fix deprecation warning - Encoding::UndefinedConversionError (#12272)

b1d86df fix 'Breakers is not implemented for service: TokenValidation' warning (#12274)

0294561 Add grandfathering feature flags for dsl and mhv (#12255)

7b4f3f7 [55722] Refactoring sign in service redirect script (#12269)

Co-authored-by: Trevor Bosaw [email protected]

871aa66 Api 25291 contention list updates (#12277)

• Split on parens with commas

• Fix test

---

Co-authored-by: Austin Covrig [email protected]

dde7aab [55722] Fixing typo in latest sign in service redirect script change that broke auth on lowers environments (#12281)

aedfafa API-23700-remove-attributes (#12280)

653cedc Updated Gemfile.lock (#12226)

• MBMS-39875 New Commit Hash

• MBMS-39875 New Commit Hash pt2

67055f4 Add new service for Letters App migration (#12183)

• Add initial lighthouse letters service

• Rubocop fixes

• More Rubocop fixes

• undo accidental changes to sm client

• Add Sentry tags

• Add positive logging

• Fix error handling bug

• Fix MORE rubocop errors

• Fix tests

• Refactor connection-specific service

• Arrested by Rubocop

• Add new line

• Renamed client for consistency

• Update fakeBadRequest.json

• Update fakeUnauthorized.json

• Update fakeResponse.json

Newlines

---

Co-authored-by: Jerek Shoemaker [email protected]

e9aad54 Update ddtrace to 1.10 (#12285)

Ubuntu was having problems installing ddtrace natively.

c5524a5 Implemented Expiry Scanner for vets-api (#12278)

• Implemented Expiry Scanner for vets-api

• Fixed rubocop errors

• Cleaned up code

• Changed expiry_scanner slack api key to argocd slack api key

---

Co-authored-by: rccassity [email protected]

vets-api/v0.0.1393

Release 0.0.1393 ami-0a7ce66b65806c69a

c2c1d02 Replace empty treatment center names with a space (#12258)

Co-authored-by: Austin Covrig [email protected]

4ba3452 API-25337 Convert SCs metadata keys to snake_case (#12235)

5306ffe Rake tasks for general-purpose appeals oauth tokens (#12264)

There are several tasks already available to fetch and validate tokens
for each set of oauth scopes used in individual appeals APIs, but this
adds tasks for the general-purpose appeals.read and appeals.write
scopes, which are respected across all of the appeals APIs.

da9b342 API-24186 Skippable benefits intake dimension checks (#12257)

Since oversized PDFs are already resized by Data Dimensions upstream,
this change lets the Benefits Intake API accept documents larger than
the current limit of 22" wide/long in either of the following cases:

1. The vba_documents_skip_dimension_check Flipper flag is on, or
2. The metadata.json submitted with the document contains the key/value
   pair { "skipDimensionCheck": true }

3eeab4b add va forms team members to flipper admin list (#12260)

vets-api/v0.0.1392

Release 0.0.1392 ami-0cd47f9ce23d7a855

6f04944 Ruby 3 upgrade: Fix form526.rake deprecations (#12263)

• replace assignment with conditional assignment operator

• namespace constants

• disable Layout/LineLength - splitting line will raise Layout/LineLength cop

• remove require 'pry' - shame on me

9c8c900 Upgrade to Ruby 3.0 (#12261)

• Update Ruby to 3.0.5

• Update the native docs to reflect 3.0.5 (#11521)

• RuboCop: Auto correct Lint/RedundantDirGlobSort

• RuboCop: Auto correct Style/RedundantFreeze (#11522)

• RuboCop: Freeze mutable constants (#11523)

• Removing no-exit-on-warn for brakeman

This was only put in place to ignore the Ruby 2.7 EOL warning.

2deafc6 Ruby 3 upgrade: Fix utilities_spec.rb deprecations (#12265)

d2c6207 API-24936-Replace-bgs-ext-claims (#12192)

• Adds local bgs for claims status

• WIP: when the key is nil???

• WIP: bgs is returning an error

• Adds default param value for key since not all bgs services have a key

• Moves bgs_service and local_bgs_service to the application controller.

• WIP: troubleshooting failing test

• WIP

• Adds back part of a failing test

• fixes cassette, changes rescue

• Removes faraday rescue

ad0b487 Removed update_appt_presentatin flag. (#12259)

3e66962 5086 verify military access in controller (#12252)

• added authorization check to controller

• fixed typo in controller

• added spec and cassette for 403 response

• fixed specs

• removed 403 yml file

• specs fix

162b4e6 Update form526 rake fix (#12268)

vets-api/v0.0.1391

Release 0.0.1391 ami-0bf8b76e1b34090c5

1d574ae removed vaos appointment service and appointment form (#12246)

7fa4eb7 removed vaos cancel form and rspec - appointment time (#12249)

7068002 [12148] Adding Sign in Service javascript redirect to prevent CORS issues when authenticating with non-va.gov Sign in Service clients (#12237)

Co-authored-by: Trevor Bosaw [email protected]

3713e63 54558 Vaos service types and category logging (#12250)

• enhanced service type and category logging

91cac65 add flipper for 26-4555 (#12248)

6d29fb7 Add github deployment logic to preview environment deployment workflow (#12251)

Co-authored-by: Curt Bonade [email protected]

0437803 remove camel case header from gender identity edit endpoint (#12224)

348737e Allow payment date to be either date or string type (#11892)

8cf46dc log user icn in enrollment_status api (#12143)

83e349b Adds correct list to docs (#12247)

5be1b9a [53995] SiS template client config (#12204)

• wip

• adds vatemplate SiS client config

• adds apitemplate

• adds cookie_template & api_template

• updates

d9a2bb8 Api 25071 faraday bgs itf (#12178)

• Incremental commit

• Remove duplicate service init, update tests

• Rubocop fixes

• Work in progress

• Work in progress

• Final fixes for xml generation

• Fix rswag test

• Rubocop corrections, misc cleanup

• Fix v1 tests

• Add handling for HTTP 500 response from BGS

• Rubocop corrections

• Log status & reason, raise error for all HTTP >=500 errors

vets-api/v0.0.1390

Release 0.0.1390 ami-0272d9f999b0d4d78

399f948 Fix syntax in Claims API specs (#12223)

e094dd6 partial removal of vaos system service rspecs (#12222)

7d00e42 removed vaos systems service and assoc classes (#12225)

2208b31 Revert "Revert "Vfep 369 - add Marriage Date to back end spool files (#12171)" (#12191)" (#12218)

This reverts commit 8985ed1.

e573205 Api 25261 itf response cleanup (#12207)

• Fix ITF response inconsistencies

• Add generated swagger files

• Adjust type for validation, add swagger

84dd247 removed vaos v0 appointment requests service (#12227)

560105b Fix another syntax in Claims API specs (#12228)

Missed one.

c02cff1 removed vaos appointment requests service assoc classes (#12230)

e0545a8 Ruby 3.1: Fix RSwag POA Request Spec (#12238)

I adopted the code from json-jwt: https://github.com/lucaskanashiro/json-jwt/blob/329bbe1b4fff6ca20f35559a9a2bd43b16498c1c/lib/json/jwk.rb#L98-L127

1be51d8 Replace levenshtein-ffi gem with build in Gem::Text (#12240)

This is a backport of a fix for Ruby 3.2. Levenshtein-ffi has a problem
install correctly (it does seem to install but app won't boot).

Gem:::Text has a built in levenshtein distance method which differs very
minorily from levenshtein-ffi. Also levenshtein-ffi hasn't been updated
in 9 years.

df0cd60 Update google-protobuf gem (#12241)

This is a back port for Ruby 3.2.

fb74a7d Update Rails to 6-1-stable (#12242)

• Rack-test needs to be locked or tests fail

fa2f2f4 Update Bundler version to 2.4.9 (#12243)

0eef06f removed vaos appointment service part 1 (#12233)

b4bb195 Update mail gem (#12245)

• Update mail gem

• Fix preneeds spec by replacing \n with \r\n in cassette

f35f83b removed vaos appointment service rspecs (#12244)

vets-api/v0.0.1389

Release 0.0.1389 ami-0de34a1b4a5bbb2ea

3a6e4e8 53997 day of check in handoff (#12167)

• 53997 initial code

• 53997 add specs

6f650f0 test branch PE deployment (#12170)

• test branch PE deployment

• test branch PE deployment

• test again

• WIP

---

Co-authored-by: Curt Bonade [email protected]

a7e4b8e RX logging changes (#12197)

f25e073 removed vaos v0 appointment serializers (#12206)

8198dbf removed vaos v0 facilitySerializer (#12211)

2ed431c removed preferences and facilities serializers (#12212)

8993dbc API-25152-cst-latest-phase-type-docs (#12210)

• changes mapping for description of tracked items to 'short_nm'

• Adds to test to verify description works with new mapping to 'short_nm'

• Adds enum to latest phase type docs

• Reverts change from other ticket

• Re-runs swagger rake task

b772efc API-25148-cst-tracked-items (#12208)

• changes mapping for description of tracked items to 'short_nm'

• Adds to test to verify description works with new mapping to 'short_nm'

• Reformats rspec test

• Adds to swagger - examples of description of tracked items.

2df8a41 Adds edipi check method and a cooresponding test. (#12156)

8203831 set unused vaos v2 serializers to no code coverage (#12217)

1cbacad removed vaos v0 direct booking eligibility criteria serializer (#12215)

5920f11 removed vaos v0 availability serializer (#12214)

a50fe0a [53049] Completing mock auth service API and sign in controller integration with sign in service mock auth (#12182)

Co-authored-by: Trevor Bosaw [email protected]

8cd069e Bundler: Add platform x86_64-linux (#12219)

5852921 [55528] Creating service for ID.me and Login.gov integrations that will create mocked records for credentials (#12216)

Co-authored-by: Trevor Bosaw [email protected]

62bf2c8 Replaces bgs-ext with local bgs for tracked items. (#12194)

1090647 Api 24327 multiple pids (#12087)

• Add multiple ID check

• Add test

• Fix nil IDs test

• Fix cop from merge

• Fix return order

• Fix nil bug

• Fix mock in tests

• Fix rubocop test

• Remove extra line

• Refactor RID in logger

• Moved multiple ID check

This reverts commit 7916f737e8b63ea44d6b8ad0d5e6c499af22de0b.

• Rename trait

• Remove extra mock in tests

• Rename factory

---

Co-authored-by: Austin Covrig [email protected]

463cb97 partial removal of vaos system service rspecs (#12221)