Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buttons default padding #465

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mstrasinskis
Copy link
Contributor

Motivation

Currently, a button tag by default has a small (0.5rem) horizontal padding. This breaks the alignment in the account menu because some entries are rendered with an a tag, which has no extra padding, while others use a button tag.

There are not so many affected buttons. For many buttons the padding is overwritten: g.e..primary, .secondary, .success, .danger, .warning (based on the button.base mixin), icon-only, 'icon'.

The buttons that are affected by the changes in this PR: .full-width, .ghost, .text, .with-icon, .card.

Changes

  • Set the padding 0 by default for buttons. This will not affect most of the buttons, only that who uses no @button.base mixin (copy button,
  • Remove padding: 0 from the places where the default padding is not needed.

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant