Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Preparation: Merge Precise Object Tagging to EOP 32-Bit #4564

Merged
merged 39 commits into from
Jun 24, 2024
Merged

Merge Preparation: Merge Precise Object Tagging to EOP 32-Bit #4564

merged 39 commits into from
Jun 24, 2024

Conversation

luc-blaeser
Copy link
Contributor

@luc-blaeser luc-blaeser commented Jun 7, 2024 •
edited
Loading

Prepare merging #4544 to #4193 (level 1 of PR stack)

crusso and others added 30 commits May 17, 2024 16:28
@crusso
subdivide ambiguous tags
6be52e1
@crusso
WIP: rts for precise tagging
7b03506
@crusso
used correct tags in compile.ml
cc85f80
@crusso
ugly attempt to tag allocations
99b2985
@crusso
implement refined tagging; refine Blob Const (WIP); todo: refine Cons…
0b0976a 
…t.Array in compile.ml
@crusso
copy, don't alias, in blob_to_text;restrict blob_of_text; generslize …
00e5895 
…stream_write_text to accept blob or text
@crusso
refine Const.Array into Const.Array and Const.Tuple to reflect precis…
6bbfdea 
…e heap tagging
@crusso
adapt incremental array slicing; fix rts tests
4981b3a
@crusso
rust format
788f403
@crusso
adapt generational array slicing; updeate bench numbers
30c91ee
@crusso
fix blob comparistion in patterns
28d98e0
@crusso
refactor slicing
4310118
@crusso
hide encoding of array tags in helpers
448962f
@crusso
refactor array_slicing
2cb651a
@crusso
Merge branch 'master' into claudio/precise-heap-tags
3de6cac
@crusso
extern array_slicing test
b44b133
@crusso
add basic tag checking on unboxing of new tags
8dbe885
@crusso
refine tags for actors and shared functions, TAG_BLOB_A and TAB_ARRAY_S
ac88615
@crusso
format
6f581c6
@crusso
implement required coercions
9f86d91
@crusso
fix bugs; extend interpreter; rename prims; add __LINE__ to Tagged.sa…
ba137c7 
…nity_check_tag
@crusso
Update rts/motoko-rts/src/debug.rs
4d41889
@crusso
document tags
0fdbc12
@crusso
reformat; implement and use blob_of_ptr_size, blob_of_str; fix base32…
0ed4fe6 
…_to_blob to produce TAG_BLOB_B
@crusso
remove unused pattern match code from compile.ml
41f8917
@crusso
use binary, not text, blob for IDL decoding check
1e8d0f6
@crusso
add more assertions
e8c4c19
@crusso
assert array tag difference is even
f5e97a9
@crusso
fix one broken assert (missing TAG_BLOB_A case); refactor other asserts
afde9e1
@crusso @luc-blaeser
Update rts/motoko-rts-tests/src/gc/heap.rs
34dd29d 
Co-authored-by: Luc Blaeser <[email protected]>
@luc-blaeser luc-blaeser changed the base branch from master to luc/stable-heap June 7, 2024 14:21
@luc-blaeser luc-blaeser self-assigned this Jun 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

Comparing from 1fd2b8f to e7bf60c:
The produced WebAssembly code seems to be completely unchanged.

@luc-blaeser luc-blaeser marked this pull request as ready for review June 7, 2024 15:14
luc-blaeser
luc-blaeser commented Jun 7, 2024
View reviewed changes
src/codegen/compile.ml Outdated Show resolved Hide resolved
luc-blaeser
luc-blaeser commented Jun 7, 2024
View reviewed changes
src/codegen/compile.ml Outdated Show resolved Hide resolved
luc-blaeser
luc-blaeser commented Jun 7, 2024
View reviewed changes
src/codegen/compile.ml Outdated Show resolved Hide resolved
luc-blaeser
luc-blaeser commented Jun 7, 2024
View reviewed changes
src/codegen/compile.ml Outdated Show resolved Hide resolved
@crusso crusso self-requested a review June 18, 2024 14:28
crusso
crusso approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked some of the additional commits on top too.

@luc-blaeser
Copy link
Contributor Author

LGTM. Checked some of the additional commits on top too.

Thank you very much!

@crusso
Copy link
Contributor

crusso commented Jun 24, 2024

(Still LGTM)

@luc-blaeser luc-blaeser merged commit e7bf60c into luc/stable-heap Jun 24, 2024
6 checks passed
@luc-blaeser luc-blaeser deleted the luc/stable-heap-merge-object-tagging branch June 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

Assignees

@luc-blaeser luc-blaeser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luc-blaeser @crusso