Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(frontend): colors #2897

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

style(frontend): colors #2897

wants to merge 9 commits into from

Conversation

loki344
Copy link
Collaborator

@loki344 loki344 commented Oct 15, 2024

Motivation

To implement the new design, I propose to match the figma variable system in our theming. This PR tackles the colors:

  • Colors are defined in the tailwind.config
  • Using the plugin mechanism we make the colors available as css variables
  • This allows us to reference the custom colors in the theme (which would otherwise result in a max callstack exceeded)

Changes

  • Define colors
  • Define theme
  • Add colors to tailwind config

This approach bases on https://dev.to/ultroneoustech/creating-multiple-themes-in-tailwind-css-and-nextjs-2e98

@loki344 loki344 requested a review from a team as a code owner October 15, 2024 13:06
@loki344 loki344 changed the title feat(frontend)/colors style(frontend)/colors Oct 15, 2024
@loki344 loki344 changed the title style(frontend)/colors style(frontend): colors Oct 15, 2024
- this forces the usage of a tw plugin/function, to automatically make the variables available. This is, because we cannot reference the custom colors in the theme itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant