feat(frontend): signer consent message #2955
Open
+162
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Before submitting any call to the IC, the OISY Wallet Signer library first fetches a consent message from the targeted canister (using the specified methods and arguments as payload) and prompts the user to decline or approve the call.
Notes
I anticipate several iterations in the future regarding this. However, from a specification standpoint, there isn’t much more we can do in terms of formatting. The standards are generic for any canister on the IC, and therefore the response currently contains only unstructured information.
Approving the consent message triggers the library to effectively execute the call canister.
Changes
/signrouteScreenshot