Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Supports the allowed viewer list for the canister log. #3921

Merged
merged 24 commits into from
Oct 3, 2024
Merged

feat: Supports the allowed viewer list for the canister log. #3921

merged 24 commits into from
Oct 3, 2024

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Sep 19, 2024 •
edited
Loading

Description

  1. Supports the allowed viewer list for the canister log.
    Valid settings are:
    • --add-log-viewer, --remove-log-viewer and --set-log-viewer flags with dfx canister update-settings
    • --log-viewer flag with dfx canister create
    • canisters[].initialization_values.log_visibility.allowed_viewers in dfx.json
  2. Bump the replica to revision 285a5db07da50a4e350ec43bf3b488cc6fe36102 which includes the flag in ic-starter.

Fixes # (issue)

SDK-1798

How Has This Been Tested?

  • Added the e2e tests

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

sesi200
sesi200 reviewed Sep 20, 2024
View reviewed changes
src/dfx-core/src/config/model/dfinity.rs Outdated Show resolved Hide resolved
src/dfx/src/lib/canister_logs/log_visibility.rs Outdated Show resolved Hide resolved
src/dfx/src/lib/canister_logs/log_visibility.rs Outdated Show resolved Hide resolved
@vincent-dfinity vincent-dfinity marked this pull request as ready for review September 24, 2024 10:14
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner September 24, 2024 10:14
maksymar
maksymar reviewed Sep 24, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
maksymar
maksymar approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@maksymar maksymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side, but I suppose someone else from DFX team should take another look.

@vincent-dfinity
Copy link
Contributor Author

LGTM from my side, but I suppose someone else from DFX team should take another look.

Yes, Severin looked this pr. And I'm waiting for the next weekly release https://github.com/dfinity/ic/releases to update the PR, and he will take a look before merging.

@sesi200 sesi200 enabled auto-merge (squash) October 3, 2024 11:24
@sesi200 sesi200 merged commit 5e57d0c into master Oct 3, 2024
297 checks passed
@sesi200 sesi200 deleted the vincent/SDK-1798 branch October 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sesi200 sesi200 sesi200 approved these changes

@maksymar maksymar maksymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vincent-dfinity @sesi200 @maksymar