Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor #33

Merged
merged 7 commits into from
Sep 19, 2024
Merged

refactor #33

merged 7 commits into from
Sep 19, 2024

Conversation

e-kwsm
Copy link
Contributor

@e-kwsm e-kwsm commented Aug 2, 2024

  • build: set cpp_std to c++11
  • fix: -Wzero-as-null-pointer-constant
  • fix: -Wlogical-not-parentheses
  • fix: modernize-redundant-void-arg
  • fix: -Wwritable-strings
  • refactor: performance-type-promotion-in-math-fn
  • refactor: readability-avoid-const-params-in-decls

@marvinfriede
Copy link
Member

Thanks for the fixes. Can this be merged?

awvwgk
awvwgk approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me

@marvinfriede
Copy link
Member

Bump @e-kwsm

@e-kwsm
Copy link
Contributor Author

e-kwsm commented Sep 19, 2024

Yes, this PR is ready.

@marvinfriede marvinfriede merged commit 4033293 into dftd4:main Sep 19, 2024
4 checks passed
@e-kwsm e-kwsm deleted the patch-1 branch September 19, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-kwsm @marvinfriede @awvwgk