IOS/Net: implement ioctlv that retrieves the network routing table that libogc now uses on network init #13066
+204
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DacoTaco
force-pushed
the
feature/networking
branch
from
64ee640
to
ff10312
Compare
DacoTaco
force-pushed
the
feature/networking
branch
from
ff10312
to
d6d962b
Compare
sepalani
suggested changes
Sep 29, 2024
There was a problem hiding this comment.
I tested this PR on some online games (e.g. Monster Hunter Tri, Mario Strikers Charged Football) and didn't find regressions. Otherwise, the PR looks mostly good to me beside some of these coding style related remarks.
Regarding Android, I might be able to implement the routing table using the RouteInfo class that we're already using to get the network properties.
DacoTaco
force-pushed
the
feature/networking
branch
from
d6d962b
to
0ba5318
Compare
|
@dolphin-emu-bot rebuild |
DacoTaco
force-pushed
the
feature/networking
branch
from
0ba5318
to
b76613f
Compare
sepalani
suggested changes
Oct 3, 2024
DacoTaco
force-pushed
the
feature/networking
branch
from
b76613f
to
357a785
Compare
…at libogc now uses on network init
DacoTaco
force-pushed
the
feature/networking
branch
from
357a785
to
c3d6d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this can be tested with the following dol's
old libogc that only retrieves the IP : sockettest_org.zip
new libogc dol that retrieves the ip, subnet mask and gateway : sockettest.zip
related libogc issue : devkitPro/libogc#179
i was only able to test & implement this decently on windows and linux, and macos/android will need to have somebody that knows those platforms look at it if it is to be implemented decently (it currently creates a fake entry for 0.0.0.0 to be sent to the retrieved gateway/broadcast ip so libogc doesn't error :) )
for macos i found this, but thats it : https://stackoverflow.com/questions/5390164/getting-routing-table-on-macosx-programmatically