Avoid static members in generic types #8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Jul 6, 2023
| @@ -220,8 +220,8 @@ public FSharpValueOption<T> DeepCopy(FSharpValueOption<T> input, CopyContext con | |||
| [RegisterSerializer] | |||
| public class FSharpChoiceCodec<T1, T2> : IFieldCodec<FSharpChoice<T1, T2>>, IDerivedTypeCodec | |||
| { | |||
| private static readonly Type ElementType1 = typeof(T1); | |||
| private static readonly Type ElementType2 = typeof(T2); | |||
| private readonly Type ElementType1 = typeof(T1); | |||
There was a problem hiding this comment.
Should we inline these instead?
There was a problem hiding this comment.
Inlining typeof(T) needs to do complex dictionary lookups (similar to static fields) in generic types with reference type parameters. An instance field access is always fast, regardless of type parameters.
There was a problem hiding this comment.
Ok, that sounds reasonable to me
There was a problem hiding this comment.
I wonder if there are places where we should lift typeof(T) to fields, then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static members in generic types are expensive, especially fields in singleton classes.
Microsoft Reviewers: Open in CodeFlow