Skip to content

Commit

Permalink
Merge pull request #7494 from dibarbet/upgrade_node
Browse files Browse the repository at this point in the history
Upgrade to Node v20.17 and update vsce
  • Loading branch information
dibarbet authored Aug 30, 2024
2 parents 5f1d0d2 + 014310e commit ff50a24
Show file tree
Hide file tree
Showing 4 changed files with 1,717 additions and 112 deletions.
7 changes: 6 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Setting up your local development environment for the vscode-csharp repository i

Before you start, make sure you have the following software installed on your machine:

* Node.js v18 ([v18.17.0 LTS](https://nodejs.org/en/blog/release/v18.17.0)).
* Node.js v18 ([v18.17.0 LTS](https://nodejs.org/en/blog/release/v20.17.0)).
* Note - Building with higher major versions of Node.js is not advised - it may work but we do not test it.
* Npm (The version shipped with node is fine)
* .NET 8.0 SDK (dotnet should be on your path)
Expand Down Expand Up @@ -141,6 +141,11 @@ Or, in VSCode settings (`Ctrl+,`):
3. Enable `razor.languageServer.debug`.
4. Set `razor.server.trace` to `Debug`. This gives you more detailed log messages in the output window.

### Updating NPM packages
We use the .NET eng AzDo artifacts feed https://dnceng.pkgs.visualstudio.com/public/_packaging/dotnet-public-npm/npm/registry/ with upstreams to the public npm registry.
Auth is required in order to pull new packages from the upstream. This can be done by running `vsts-npm-auth -config .npmrc`.
If you need to renew authorization, you can force it via `vsts-npm-auth -config .npmrc -F`

## Creating VSIX Packages for the Extension

To package this extension, we need to create VSIX Packages. The VSIX packages can be created using the gulp command `gulp vsix:release:package`. This will create all the platform specific VSIXs that you can then install manually in VSCode.
Expand Down
4 changes: 2 additions & 2 deletions azure-pipelines/prereqs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ steps:
- task: NuGetAuthenticate@1

- task: NodeTool@0
displayName: 'Install Node.js 18.x'
displayName: 'Install Node.js 20.x'
inputs:
versionSpec: '18.x'
versionSpec: '20.x'

# Some tests use predefined docker images with a specific version of .NET installed.
# So we avoid installing .NET in those cases.
Expand Down
Loading

0 comments on commit ff50a24

Please sign in to comment.